Skip to content

feat: validate db schemas CI test #4094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 14, 2025
Merged

Conversation

DanielHougaard
Copy link
Member

Description 📣

This PR introduces a new CI test to verify that the database state matches the committed schemas.

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

@DanielHougaard DanielHougaard self-assigned this Jul 13, 2025
@DanielHougaard DanielHougaard marked this pull request as ready for review July 13, 2025 15:39
@maidul98
Copy link
Collaborator

maidul98 commented Jul 13, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Added a new CI workflow to validate database schemas against committed versions, helping prevent schema drift and inconsistencies.

  • Added .github/workflows/validate-db-schemas.yml that triggers on PR events affecting backend/src/db/**, runs migrations and compares generated schemas with committed ones
  • Created automatic validation checks that fail CI if schema changes are not properly documented and committed
  • Modified .infisicalignore to handle API keys in the new workflow configuration
  • Leverages existing Docker configurations from other workflows for consistent test environments
  • Implements proper cleanup of test resources after schema validation

2 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

@x032205 x032205 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments

@DanielHougaard DanielHougaard merged commit f6d337c into main Jul 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants