Skip to content

improvement(frontend): make secret overview table header sticky, add underlines to env header links and limit table height for scroll #4298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

scott-ray-wilson
Copy link
Contributor

Description 📣

This PR updates the secret overview table to have a sticky header, adds underlines to env col headers to make more clear they are links, and limits table height and adds scroll to ensure explore/headers are always visible

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

… to env header links and limit table height for scroll
@maidul98
Copy link
Collaborator

maidul98 commented Aug 1, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR introduces UI improvements to the secret overview table in the frontend to enhance user experience when working with large secret datasets. The changes focus on three main areas:

  1. Sticky Header Implementation: Adds sticky top-0 z-20 classes to the THead component, ensuring column headers remain visible during vertical scrolling. This maintains context when users navigate through extensive secret lists.

  2. Table Height Constraints: Implements max-h-[66vh] overflow-y-auto on the TableContainer to limit the table's vertical space consumption to 66% of viewport height. This ensures other UI elements like navigation and exploration tools remain accessible even with large datasets.

  3. Visual Affordance Improvements: Adds underline class to environment header text (<p className="truncate font-medium underline">{name}</p>) to clearly indicate these headers are clickable links, improving user understanding of interactive elements.

The changes also include removing the thin-scrollbar class from the outer div wrapper while maintaining it on the TableContainer for consistent styling. These modifications work together to create a more navigable and user-friendly interface for the secret management workflow, particularly beneficial when dealing with multiple environments and large numbers of secrets.

Confidence score: 5/5

  • This PR is safe to merge with minimal risk as it only contains cosmetic UI improvements
  • Score reflects simple, well-targeted changes that enhance usability without affecting core functionality
  • No files require special attention as changes are straightforward CSS class additions

1 file reviewed, no comments

Edit Code Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants