-
Notifications
You must be signed in to change notification settings - Fork 62
Fix/synced dev with v1 14 core and indexer #287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ve indexer v1.14.1-RC.6
WalkthroughThe changes update branch references in the Makefile and version settings in the go.mod file. In the Makefile, the branch names for the Changes
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
go.mod (2)
7-39: Main Require Block Dependency Version Updates
Several core dependencies have been updated:
cosmossdk.io/x/upgradeis now at v0.1.4.github.com/btcsuite/btcdhas been updated to v0.24.2.github.com/cometbft/cometbftis now listed at v0.38.11.github.com/cosmos/cosmos-sdkbumped to v0.50.9.github.com/cosmos/gogoprotonow at v1.7.0.github.com/stretchr/testifyupgraded to v1.10.0, among others.Please review the upstream release notes for these libraries to ensure there are no breaking changes for your codebase.
231-246: Replace Directives Adjustments
Thereplacesection has been updated for key modules:
github.com/CosmWasm/wasmdnow points togithub.com/InjectiveLabs/wasmd v0.53.2-inj-1.github.com/cometbft/cometbftis now replaced withgithub.com/InjectiveLabs/cometbft v0.38.17-inj-0.These changes are critical for ensuring that your project uses the fixed or patched versions of these dependencies. Verify that all imports and dependencies throughout the codebase are consistent with these replacements.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (3)
exchange/explorer_rpc/pb/goadesign_goagen_injective_explorer_rpc.pb.gois excluded by!**/*.pb.goexchange/explorer_rpc/pb/goadesign_goagen_injective_explorer_rpc_grpc.pb.gois excluded by!**/*.pb.gogo.sumis excluded by!**/*.sum
📒 Files selected for processing (2)
Makefile(1 hunks)go.mod(8 hunks)
🔇 Additional comments (5)
Makefile (2)
3-5: Updated Injective-Indexer Clone Target
The clone command for theinjective-indexertarget is now using branchv1.14.1-RC.6. Please verify that this branch name (with its release candidate suffix) is correct and that the remote repository’s branch is stable.
6-8: Updated Injective-Core Clone Target
Theclone-injective-coretarget now clones from branchv1.14.0instead of the previoustestnetbranch. Confirm that this change is intentional and that all downstream modules and scripts correctly handle the new repository structure.go.mod (3)
1-5: Updated Go Version and Toolchain Directive
The Go version has been bumped to1.22.11and the toolchain updated togo1.23.5. These changes ensure compatibility with newer dependency versions. Make sure your build and CI pipelines are adjusted for these versions.
41-229: Indirect Dependency Updates Verification
In the indirect require block, several dependencies have seen version changes (for example, updates incosmossdk.io/logand others). While these are less direct, it is essential to run comprehensive integration tests to ensure that none of these updates introduce unforeseen issues.
1-247: Overall Dependency Update Assessment
The updates in thisgo.modfile align with the objective of synchronizing with Injective core v1.14.0 and indexer v1.14.1-RC.6. It is recommended to run your full test suite to catch any integration issues resulting from these dependency bumps and replacements.
Summary by CodeRabbit