Skip to content

Conversation

@aarmoa
Copy link
Collaborator

@aarmoa aarmoa commented Feb 10, 2025

  • updated dependencies to match injective core v1.14.0 and injective indexer v1.14.1-RC.6

Summary by CodeRabbit

  • Chores
    • Updated branch references for key components to newer release versions.
    • Upgraded the underlying environment by using an updated Go version, toolchain, and various dependency releases to enhance compatibility, performance, and stability.

@coderabbitai
Copy link

coderabbitai bot commented Feb 10, 2025

Walkthrough

The changes update branch references in the Makefile and version settings in the go.mod file. In the Makefile, the branch names for the injective-indexer and injective-core clone targets were updated to newer versions. In the go.mod file, the Go version and toolchain have been upgraded, along with several dependency version bumps and adjustments in the replace section. These updates ensure that the project uses more recent versions of libraries and tools.

Changes

File Change Summary
Makefile Updated branch in clone-injective-indexer from v1.13.117_RC1 to v1.14.1-RC.6 and in clone-injective-core from testnet to v1.14.0.
go.mod Upgraded Go version from 1.22.2 to 1.22.11 and toolchain from go1.22.5 to go1.23.5; incremented versions for multiple dependencies (e.g., cosmossdk.io/x/upgrade, btcsuite/btcd, cosmos-sdk, gogoproto, testify, grpc, prometheus, etc.); updated indirect dependencies and modified the replace section for CosmosWasm/wasmd.

Poem

I'm a rabbit with a skip and a hop,
Code changes in the breeze, making my heart go pop!
Branches updated, dependencies new,
In Makefile and go.mod, fresh versions accrue.
With a twitch of my whiskers and a byte in my code,
I celebrate these updates down my digital road!
🐇✨


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
go.mod (2)

7-39: Main Require Block Dependency Version Updates
Several core dependencies have been updated:

  • cosmossdk.io/x/upgrade is now at v0.1.4.
  • github.com/btcsuite/btcd has been updated to v0.24.2.
  • github.com/cometbft/cometbft is now listed at v0.38.11.
  • github.com/cosmos/cosmos-sdk bumped to v0.50.9.
  • github.com/cosmos/gogoproto now at v1.7.0.
  • github.com/stretchr/testify upgraded to v1.10.0, among others.

Please review the upstream release notes for these libraries to ensure there are no breaking changes for your codebase.


231-246: Replace Directives Adjustments
The replace section has been updated for key modules:

  • github.com/CosmWasm/wasmd now points to github.com/InjectiveLabs/wasmd v0.53.2-inj-1.
  • github.com/cometbft/cometbft is now replaced with github.com/InjectiveLabs/cometbft v0.38.17-inj-0.

These changes are critical for ensuring that your project uses the fixed or patched versions of these dependencies. Verify that all imports and dependencies throughout the codebase are consistent with these replacements.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dc1963f and d2d2e57.

⛔ Files ignored due to path filters (3)
  • exchange/explorer_rpc/pb/goadesign_goagen_injective_explorer_rpc.pb.go is excluded by !**/*.pb.go
  • exchange/explorer_rpc/pb/goadesign_goagen_injective_explorer_rpc_grpc.pb.go is excluded by !**/*.pb.go
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • Makefile (1 hunks)
  • go.mod (8 hunks)
🔇 Additional comments (5)
Makefile (2)

3-5: Updated Injective-Indexer Clone Target
The clone command for the injective-indexer target is now using branch v1.14.1-RC.6. Please verify that this branch name (with its release candidate suffix) is correct and that the remote repository’s branch is stable.


6-8: Updated Injective-Core Clone Target
The clone-injective-core target now clones from branch v1.14.0 instead of the previous testnet branch. Confirm that this change is intentional and that all downstream modules and scripts correctly handle the new repository structure.

go.mod (3)

1-5: Updated Go Version and Toolchain Directive
The Go version has been bumped to 1.22.11 and the toolchain updated to go1.23.5. These changes ensure compatibility with newer dependency versions. Make sure your build and CI pipelines are adjusted for these versions.


41-229: Indirect Dependency Updates Verification
In the indirect require block, several dependencies have seen version changes (for example, updates in cosmossdk.io/log and others). While these are less direct, it is essential to run comprehensive integration tests to ensure that none of these updates introduce unforeseen issues.


1-247: Overall Dependency Update Assessment
The updates in this go.mod file align with the objective of synchronizing with Injective core v1.14.0 and indexer v1.14.1-RC.6. It is recommended to run your full test suite to catch any integration issues resulting from these dependency bumps and replacements.

@aarmoa aarmoa merged commit 49b9c7f into dev Feb 10, 2025
4 of 5 checks passed
@aarmoa aarmoa deleted the fix/synced_dev_with_v1_14_core_and_indexer branch February 10, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants