Skip to content

Conversation

@aarmoa
Copy link
Collaborator

@aarmoa aarmoa commented Apr 16, 2025

  • PR to sync dev branch with the latest changes in master after the v1.57 release

Summary by CodeRabbit

  • Chores
    • Updated repository branch versions in the build process for improved compatibility.
  • Refactor
    • Simplified internal dependencies and cleaned up unused code in the client context.

aarmoa and others added 2 commits April 16, 2025 16:33
* feat: removed the deprecated pre-commit repo pre-commit-golang. Added new CI step to run golangci-lint using the github action

* fix: added skip directories into the golanci lint config

* fix: fixed lint errors

* fix: fixed lint errors

* feat: updated proto definitions for the chain upgrade v1.15

* fix: synced go.mod dependecnies with Injective core

* fix: fixed lint errors

* fix: fixed lint errors

* feat: updated all proto definitions for v1.15 chain upgrade. Added an example for the new GetEipBaseFee request in txfees module

* feat: updated all examples to query gas price from the chain instead of using the default value

* Feat/sync with master v1.56.2 (#298)

* (fix) Applied the fixes for EIP712 JSON unmarshalling to the master branch

* fix: update pre-commit/action from v2.0.2 to v3.0.1 to ry to solve the pre-commit validation workflow error

* fix: Added configuration in .golangci.yml file to exclude some dirs

* fix: updated the oracle stream prices script to send the oracle type always in lowercase

* fix: updated the oracle stream prices script to send the oracle type always in lowercase

* fix: Added quantization in the functions that convert notional values to chain format

* fix/fix_manual_tx_generation (#296)

* fix: fixed the manual TX generation and signing to receive the gas price

* fix: solve issues in pre-commit workflow caused by using deprecated components

* fix: solve issues in pre-commit workflow caused by using deprecated components

* feat: updated proto definitions for the chain upgrade v1.15

* (fix) Applied the fixes for EIP712 JSON unmarshalling to the master branch

* fix: updated the oracle stream prices script to send the oracle type always in lowercase

* fix: updated the oracle stream prices script to send the oracle type always in lowercase

* fix: synced go.mod dependecnies with Injective core

* fix: fixed lint errors

* fix: fixed lint errors

* feat: updated all proto definitions for v1.15 chain upgrade. Added an example for the new GetEipBaseFee request in txfees module

* feat: updated all examples to query gas price from the chain instead of using the default value

* fix: fix function parameter type

* feat: updated proto definition to v1.15.0-beta.2 and v1.14.48 for Indexer

* fix: update ofac.json file

* Improve error messaging and enhance documentation in eip712_cosmos.go (#240)

This PR improves error handling and enhances documentation in the
eip712_cosmos.go file to provide clearer messages and more detailed
explanations.

Signed-off-by: Hwangjae Lee <meetrick@gmail.com>
Co-authored-by: Abel Armoa <30988000+aarmoa@users.noreply.github.com>

* fix: fixed array creatin in a unit test (#299)

* fix: updated chain version to v1.15 and indexer version to v1.15.6

* fix: removed explicit inclusion of txfees response in the context initialization (not required)

---------

Signed-off-by: Hwangjae Lee <meetrick@gmail.com>
Co-authored-by: Hwangjae Lee <meetrick@gmail.com>
@coderabbitai
Copy link

coderabbitai bot commented Apr 16, 2025

Walkthrough

The changes update branch versions for two repositories in the Makefile, adjusting which versions are cloned during builds. Additionally, in the Go client context code, an import alias is removed and a specific type registration related to transaction fee queries is deleted from the client context initialization. No other logic or exported/public entity declarations are altered.

Changes

File(s) Change Summary
Makefile Updated git clone commands to use new branch versions for injective-indexer and injective-core.
client/chain/context.go Removed import alias for Cosmos SDK types and deleted explicit interface registration for a fee type.

Poem

In the warren of code, a branch hops anew,
Makefile points to fresher dew.
Context sheds an alias, light as spring,
No more fee type registration in its ring.
With every tweak, the garden grows—
A rabbit’s joy in tidy rows! 🐇🌱

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6be9ce4 and a07df50.

⛔ Files ignored due to path filters (1)
  • exchange/explorer_rpc/pb/goadesign_goagen_injective_explorer_rpc.pb.go is excluded by !**/*.pb.go
📒 Files selected for processing (2)
  • Makefile (1 hunks)
  • client/chain/context.go (0 hunks)
💤 Files with no reviewable changes (1)
  • client/chain/context.go
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: lint
  • GitHub Check: run-tests
🔇 Additional comments (2)
Makefile (2)

4-4: Dependency version bump for injective-indexer looks good.

The branch update to v1.15.6 for injective-indexer is clear and aligns with the PR's synchronization objective.


7-7: Dependency version bump for injective-core looks good.

The branch update to v1.15.0 for injective-core is appropriate for aligning with upstream changes.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@aarmoa aarmoa merged commit 77e624d into dev Apr 16, 2025
6 checks passed
@aarmoa aarmoa deleted the fix/rebase_dev_with_v1_57 branch April 16, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants