-
Notifications
You must be signed in to change notification settings - Fork 62
[chore] update indexer v1.16.20 #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… with requests or response changes
WalkthroughThe Makefile was updated to use the Changes
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Makefile (1)
4-4: Verify the new indexer version and clean up legacy comments
The clone target has been bumped tov1.16.20. Please confirm that this branch or tag actually exists upstream. Also consider updating or removing the commented-out legacy clone block (around lines 188–190) to prevent confusion in future maintenance.Run this script to verify the remote refs:
#!/bin/bash # Verify that v1.16.20 exists in injective-indexer git ls-remote --tags https://github.com/InjectiveLabs/injective-indexer.git v1.16.20 git ls-remote --heads https://github.com/InjectiveLabs/injective-indexer.git refs/heads/v1.16.20
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (3)
exchange/event_provider_api/pb/goadesign_goagen_event_provider_api.pb.gois excluded by!**/*.pb.goexchange/event_provider_api/pb/goadesign_goagen_event_provider_api_grpc.pb.gois excluded by!**/*.pb.goexchange/explorer_rpc/pb/goadesign_goagen_injective_explorer_rpc.pb.gois excluded by!**/*.pb.go
📒 Files selected for processing (1)
Makefile(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: run-tests
- GitHub Check: lint
- GitHub Check: pre-commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the gRPC client/server stubs and protocol definitions to support the new StreamLatestHeight streaming RPC introduced in indexer v1.16.20, and bumps the cloned indexer dependency version.
- Adds
StreamLatestHeightmethods to client interface, implementation, server interface, handler, and service descriptor. - Updates indexing of
EventProviderAPI_ServiceDesc.Streamsfor bothStreamLatestHeightand existingStreamBlockEvents. - Bumps the
injective-indexergit clone version in the Makefile to v1.16.20.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| exchange/event_provider_api/pb/goadesign_goagen_event_provider_api_grpc.pb.go | Generated stubs for new StreamLatestHeight RPC |
| Makefile | Updated injective-indexer clone to v1.16.20 |
Comments suppressed due to low confidence (1)
exchange/event_provider_api/pb/goadesign_goagen_event_provider_api_grpc.pb.go:58
- There are no tests covering the new
StreamLatestHeightclient and server behavior. Consider adding unit or integration tests that simulate sending and receiving a stream ofStreamLatestHeightResponsemessages to verify both client stub and handler logic.
func (c *eventProviderAPIClient) StreamLatestHeight(ctx context.Context, in *StreamLatestHeightRequest, opts ...grpc.CallOption) (EventProviderAPI_StreamLatestHeightClient, error) {
| all: | ||
|
|
||
| clone-injective-indexer: | ||
| git clone https://github.com/InjectiveLabs/injective-indexer.git -b v1.16.16 --depth 1 --single-branch | ||
| git clone https://github.com/InjectiveLabs/injective-indexer.git -b v1.16.20 --depth 1 --single-branch |
Copilot
AI
Jun 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Hard-coding the indexer version in the Makefile can lead to duplication when bumping versions elsewhere. Consider extracting the version into a variable (e.g. INDEXER_VERSION := v1.16.20) and referencing it in the clone command for easier future updates.
Summary by CodeRabbit
injective-indexerrepository.