Skip to content

Conversation

@aarmoa
Copy link
Collaborator

@aarmoa aarmoa commented Jun 16, 2025

  • Updated proto definitions for indexer v1.16.20
  • Updated queries with requests or response changes

Summary by CodeRabbit

  • Chores
    • Updated the branch version used for cloning the injective-indexer repository.

@aarmoa aarmoa requested a review from Copilot June 16, 2025 20:37
@coderabbitai
Copy link

coderabbitai bot commented Jun 16, 2025

Walkthrough

The Makefile was updated to use the v1.16.20 branch instead of v1.16.16 when cloning the injective-indexer repository. No other modifications or logic changes were introduced.

Changes

File Change Summary
Makefile Updated branch version for injective-indexer clone

Poem

A tweak in the Makefile, small but neat,
The branch hops forward, a version complete.
From sixteen to twenty, the code will now flow,
As rabbits rejoice in the progress we show!
🐇✨


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
Makefile (1)

4-4: Verify the new indexer version and clean up legacy comments
The clone target has been bumped to v1.16.20. Please confirm that this branch or tag actually exists upstream. Also consider updating or removing the commented-out legacy clone block (around lines 188–190) to prevent confusion in future maintenance.

Run this script to verify the remote refs:

#!/bin/bash
# Verify that v1.16.20 exists in injective-indexer
git ls-remote --tags https://github.com/InjectiveLabs/injective-indexer.git v1.16.20
git ls-remote --heads https://github.com/InjectiveLabs/injective-indexer.git refs/heads/v1.16.20
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between be05f2b and f1c6e3d.

⛔ Files ignored due to path filters (3)
  • exchange/event_provider_api/pb/goadesign_goagen_event_provider_api.pb.go is excluded by !**/*.pb.go
  • exchange/event_provider_api/pb/goadesign_goagen_event_provider_api_grpc.pb.go is excluded by !**/*.pb.go
  • exchange/explorer_rpc/pb/goadesign_goagen_injective_explorer_rpc.pb.go is excluded by !**/*.pb.go
📒 Files selected for processing (1)
  • Makefile (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: run-tests
  • GitHub Check: lint
  • GitHub Check: pre-commit

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the gRPC client/server stubs and protocol definitions to support the new StreamLatestHeight streaming RPC introduced in indexer v1.16.20, and bumps the cloned indexer dependency version.

  • Adds StreamLatestHeight methods to client interface, implementation, server interface, handler, and service descriptor.
  • Updates indexing of EventProviderAPI_ServiceDesc.Streams for both StreamLatestHeight and existing StreamBlockEvents.
  • Bumps the injective-indexer git clone version in the Makefile to v1.16.20.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
exchange/event_provider_api/pb/goadesign_goagen_event_provider_api_grpc.pb.go Generated stubs for new StreamLatestHeight RPC
Makefile Updated injective-indexer clone to v1.16.20
Comments suppressed due to low confidence (1)

exchange/event_provider_api/pb/goadesign_goagen_event_provider_api_grpc.pb.go:58

  • There are no tests covering the new StreamLatestHeight client and server behavior. Consider adding unit or integration tests that simulate sending and receiving a stream of StreamLatestHeightResponse messages to verify both client stub and handler logic.
func (c *eventProviderAPIClient) StreamLatestHeight(ctx context.Context, in *StreamLatestHeightRequest, opts ...grpc.CallOption) (EventProviderAPI_StreamLatestHeightClient, error) {

Comment on lines 1 to +4
all:

clone-injective-indexer:
git clone https://github.com/InjectiveLabs/injective-indexer.git -b v1.16.16 --depth 1 --single-branch
git clone https://github.com/InjectiveLabs/injective-indexer.git -b v1.16.20 --depth 1 --single-branch
Copy link

Copilot AI Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Hard-coding the indexer version in the Makefile can lead to duplication when bumping versions elsewhere. Consider extracting the version into a variable (e.g. INDEXER_VERSION := v1.16.20) and referencing it in the clone command for easier future updates.

Copilot uses AI. Check for mistakes.
@aarmoa aarmoa merged commit f6dd233 into dev Jun 16, 2025
6 checks passed
@aarmoa aarmoa deleted the chore/update_indexer_v1_16_20 branch June 16, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants