-
Notifications
You must be signed in to change notification settings - Fork 62
[chore] update example scripts #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA new JSON file named Changes
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
examples/chain/exchange/query/57_GrantAuthorization/injective_data/ofac.json (2)
2-75: Enforce consistent address casing or use EIP-55 checksum format.Most entries are lowercase, but some (e.g., line 71) use mixed-case. To avoid typos and improve integrity checks, convert all addresses to checksum-case per EIP-55 or uniformly lowercase.
1-76: Add context or metadata for the OFAC address list.As a bare array, the purpose and source of these addresses aren’t self-evident. Consider wrapping them in an object with a descriptive key (e.g.,
{ "ofac_addresses": […] }), adding a JSON schema, or including a README to document their provenance and usage.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
examples/chain/exchange/query/57_GrantAuthorization/injective_data/ofac.json(1 hunks)
🔇 Additional comments (2)
examples/chain/exchange/query/57_GrantAuthorization/injective_data/ofac.json (2)
1-76: OFAC list addition looks correct.The JSON is valid, properly formatted, and the array contains the intended Ethereum-style addresses.
2-75: Verify uniqueness of the address list.With dozens of entries, it’s prudent to ensure no duplicates slipped in. You can run:
#!/bin/bash # Description: Check for duplicate addresses in ofac.json jq -r '.[]' examples/chain/exchange/query/57_GrantAuthorization/injective_data/ofac.json \ | sort | uniq -d
Summary by CodeRabbit