[FIX] Fix go.mod dependencies to match Injective core v1.18.0#348
[FIX] Fix go.mod dependencies to match Injective core v1.18.0#348
Conversation
There was a problem hiding this comment.
Pull request overview
Updates this repo’s Go module replacement pins to align with Injective core v1.18.0 by bumping Injective fork versions for Cosmos SDK and Go-Ethereum.
Changes:
- Bump
github.com/InjectiveLabs/cosmos-sdk(and submodules used viacosmossdk.io/*replaces) fromv0.50.14-injtov0.50.14-inj.4. - Bump
github.com/InjectiveLabs/go-ethereumfromv1.16.3-injtov1.16.3-inj.2. - Update
go.sumentries to match the new replaced module versions and checksums.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| go.mod | Updates replace directives to newer Injective fork versions for Cosmos SDK modules and Go-Ethereum. |
| go.sum | Refreshes sums for the updated Injective fork module versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -254,7 +254,7 @@ replace ( | |||
|
|
|||
| github.com/cometbft/cometbft => github.com/InjectiveLabs/cometbft v1.0.1-inj.6 | |||
| github.com/cometbft/cometbft/api => github.com/InjectiveLabs/cometbft/api v1.0.0-inj.2 | |||
There was a problem hiding this comment.
replace github.com/cosmos/cosmos-sdk => ... v0.50.14-inj.4 now points at a newer fork than the require github.com/cosmos/cosmos-sdk v0.50.12 version earlier in the file. Even though the replace will override the code for this module, leaving require behind can be confusing and can cause downstream consumers (who don't apply this module's replace directives) to resolve an unexpected SDK version. Consider updating the require version to the matching upstream tag (e.g., v0.50.14) or otherwise documenting/enforcing the expected fork/version.
| github.com/cometbft/cometbft/api => github.com/InjectiveLabs/cometbft/api v1.0.0-inj.2 | |
| github.com/cometbft/cometbft/api => github.com/InjectiveLabs/cometbft/api v1.0.0-inj.2 | |
| // NOTE: This module is built and tested against the InjectiveLabs fork of | |
| // github.com/cosmos/cosmos-sdk at v0.50.14-inj.4 (tracking upstream v0.50.14). | |
| // Downstream consumers should either pin the same upstream version or add | |
| // an equivalent replace directive to ensure they use a compatible SDK. |
| // geth dev | ||
| github.com/ethereum/go-ethereum => github.com/InjectiveLabs/go-ethereum v1.16.3-inj | ||
| github.com/ethereum/go-ethereum => github.com/InjectiveLabs/go-ethereum v1.16.3-inj.2 |
There was a problem hiding this comment.
Similar to cosmos-sdk, this replace github.com/ethereum/go-ethereum => ... v1.16.3-inj.2 is ahead of the require github.com/ethereum/go-ethereum v1.15.7 declared earlier. To keep the module metadata aligned (and reduce surprises for consumers that won't see these replaces), consider bumping the require version to v1.16.3 as well.
Fix go.mod dependencies to match Injective core v1.18.0