feat: communicationRequest to edition File #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonDmz
force-pushed
the
feature-generate-xml-from-communication-requests
branch
from
9639475
to
50d4265
Compare
BettyB979
reviewed
Oct 16, 2024
src/main/java/fr/insee/pearljam/batch/dao/CommunicationRequestDaoImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/fr/insee/pearljam/batch/dao/CommunicationRequestStatusDaoImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/fr/insee/pearljam/batch/exception/MissingCommunicationException.java
Show resolved
Hide resolved
src/main/java/fr/insee/pearljam/batch/exception/PublicationException.java
Show resolved
Hide resolved
src/main/java/fr/insee/pearljam/batch/service/impl/CommunicationServiceImpl.java
Show resolved
Hide resolved
davdarras
reviewed
Oct 17, 2024
src/main/java/fr/insee/pearljam/batch/dao/VisibilityDaoImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/fr/insee/pearljam/batch/dao/VisibilityDaoImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/fr/insee/pearljam/batch/service/impl/CommunicationServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/fr/insee/pearljam/batch/service/impl/CommunicationServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/fr/insee/pearljam/batch/service/impl/CommunicationServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/fr/insee/pearljam/batch/service/impl/CommunicationServiceImpl.java
Show resolved
Hide resolved
src/main/java/fr/insee/pearljam/batch/service/impl/CommunicationServiceImpl.java
Show resolved
Hide resolved
src/main/java/fr/insee/pearljam/batch/service/impl/MeshuggahServiceImpl.java
Show resolved
Hide resolved
fix: prevent "null" serialization in address fields
davdarras
reviewed
Oct 23, 2024
| @@ -221,7 +222,7 @@ public BatchErrorCode handleCommunications() throws SynchronizationException, Mi | |||
| variables.setBarcode(barCode); | |||
|
|
|||
| // Set InitAccuseReception based on some business logic | |||
| variables.setInitAccuseReception(template.isInitAccuseReception()); | |||
| variables.setInitAccuseReception(template.isInitAccuseReception()?"oui":"non"); | |||
davdarras
requested changes
Oct 23, 2024
|
davdarras
approved these changes
Oct 25, 2024
SimonDmz
added a commit
that referenced
this pull request
Oct 25, 2024
* feat: communicationRequest to edition File * feat: interviewer title synchro * fix: back to javax.xml imports * fix: resolve Jaxb Factory bug * fix: resolve Jaxb Factory bug again * fix: resolve Jaxb bug even more * fix: person title mapping * feat: allow natural splitting fix: prevent "null" serialization in address fields * fix: handle api call error and file move error independently * fix: truncate overflowing L3 at 38 chars, don't include null as string in address * fix: clean sql in string block, remove unused code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.