fix tests

InseeFr · Jan 24, 2024 · df9785c · df9785c
1 parent e17a8e1
commit df9785c
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 11 deletions.
diff --git a/src/reducers/errors/errors-visualization.js b/src/reducers/errors/errors-visualization.js
@@ -10,7 +10,7 @@ const actionHandlers = {};
 export function addVisualizationError(state, { error }) {
   return {
     ...state,
-    showErrorVisualizationPopup: error.message,
+    showErrorVisualizationPopup: error?.message,
   };
 }
 

diff --git a/src/reducers/errors/errors-visualization.spec.js b/src/reducers/errors/errors-visualization.spec.js
@@ -10,25 +10,37 @@ import {
 
 describe('addVisualizationError', () => {
   test('when called directly', () => {
-    const result = addVisualizationError({
-      showErrorVisualizationPopup: false,
-    });
+    const result = addVisualizationError(
+      {
+        showErrorVisualizationPopup: '',
+      },
+      {
+        error: {
+          message: 'visualisation error message',
+        },
+      },
+    );
     expect(result).toEqual({
-      showErrorVisualizationPopup: true,
+      showErrorVisualizationPopup: 'visualisation error message',
     });
   });
   [ADD_VISUALIZATION_ERROR].forEach(action => {
     test(`when called when we trigger ${action}`, () => {
       const result = actionsHandlers(
         {
-          showErrorVisualizationPopup: false,
+          showErrorVisualizationPopup: '',
         },
         {
           type: action,
+          payload: {
+            error: {
+              message: 'handler visualisation error message',
+            },
+          },
         },
       );
       expect(result).toEqual({
-        showErrorVisualizationPopup: true,
+        showErrorVisualizationPopup: 'handler visualisation error message',
       });
     });
   });
@@ -37,24 +49,26 @@ describe('addVisualizationError', () => {
 describe('removeVisualizationError', () => {
   test('when called directly', () => {
     const result = removeVisualizationError({
-      showErrorVisualizationPopup: true,
+      showErrorVisualizationPopup:
+        'il y a quelque chose de pourri au royaume de Danemark',
     });
     expect(result).toEqual({
-      showErrorVisualizationPopup: false,
+      showErrorVisualizationPopup: '',
     });
   });
   [REMOVE_VISUALIZATION_ERROR].forEach(action => {
     test(`when called when we trigger ${action}`, () => {
       const result = actionsHandlers(
         {
-          showErrorVisualizationPopup: true,
+          showErrorVisualizationPopup:
+            'il y a quelque chose de pourri au royaume de Danemark',
         },
         {
           type: action,
         },
       );
       expect(result).toEqual({
-        showErrorVisualizationPopup: false,
+        showErrorVisualizationPopup: '',
       });
     });
   });