refactor: resolve sonar issues

InseeFr · Jul 19, 2024 · dcf9fd8 · dcf9fd8
1 parent f5c207c
commit dcf9fd8
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 17 deletions.
diff --git a/...ion/src/test/java/fr/insee/queen/application/configuration/springdoc/DummyController.java b/...ion/src/test/java/fr/insee/queen/application/configuration/springdoc/DummyController.java
@@ -6,10 +6,16 @@
 public class DummyController {
 
     @PreAuthorize(AuthorityPrivileges.HAS_USER_PRIVILEGES)
-    public void testMethodHasUserPrivileges() {}
+    public void testMethodHasUserPrivileges() {
+        // used to verify ACL
+    }
 
     @PreAuthorize(AuthorityPrivileges.HAS_INTERVIEWER_PRIVILEGES + "||" + AuthorityPrivileges.HAS_ADMIN_PRIVILEGES )
-    public void testMethodMultiplePrivileges() {}
+    public void testMethodMultiplePrivileges() {
+        // used to verify ACL
+    }
 
-    public void testMethodNoPreauthorize() {}
+    public void testMethodNoPreauthorize() {
+        // used to verify ACL
+    }
 }
diff --git a/...c/test/java/fr/insee/queen/application/pilotage/controller/InterviewerControllerTest.java b/...c/test/java/fr/insee/queen/application/pilotage/controller/InterviewerControllerTest.java
@@ -30,15 +30,15 @@ void testGetInterviewerCampaigns01() {
         List<CampaignSummaryDto> campaigns = interviewerController.getInterviewerCampaignList("userId");
         assertThat(pilotageComponent.isWentThroughInterviewerCampaigns()).isTrue();
         assertThat(campaigns).hasSize(2);
-        assertThat(campaigns.get(0).getId()).isEqualTo(PilotageFakeComponent.CAMPAIGN1_ID);
+        assertThat(campaigns.getFirst().getId()).isEqualTo(PilotageFakeComponent.CAMPAIGN1_ID);
     }
 
     @Test
     @DisplayName("On retrieving survey units for a campaign, then return survey units from pilotage service")
     void testGetSurveyUnitsCampaign01() {
         List<SurveyUnitByCampaignDto> surveyUnits = interviewerController.getListSurveyUnitByCampaign("campaign-id");
         assertThat(surveyUnits).hasSize(2);
-        assertThat(surveyUnits.get(0).id()).isEqualTo(PilotageFakeComponent.SURVEY_UNIT1_ID);
+        assertThat(surveyUnits.getFirst().id()).isEqualTo(PilotageFakeComponent.SURVEY_UNIT1_ID);
     }
 
     @Test
@@ -57,13 +57,4 @@ void testGetSurveyUnitsForInterviewers03() {
         assertThat(surveyUnits.get(0).id()).isEqualTo(PilotageFakeComponent.SURVEY_UNIT1_ID);
         assertThat(surveyUnits.get(1).id()).isEqualTo(PilotageFakeComponent.SURVEY_UNIT2_ID);
     }
-
-    @Test
-    @DisplayName("On retrieving survey units for an interviewer, return survey units found")
-    void testGetSurveyUnitsForInterviewers04() {
-        List<SurveyUnitDto> surveyUnits =  interviewerController.getInterviewerSurveyUnits();
-        assertThat(surveyUnits).size().isEqualTo(2);
-        assertThat(surveyUnits.get(0).id()).isEqualTo(PilotageFakeComponent.SURVEY_UNIT1_ID);
-        assertThat(surveyUnits.get(1).id()).isEqualTo(PilotageFakeComponent.SURVEY_UNIT2_ID);
-    }
 }
diff --git a/...ication/src/test/java/fr/insee/queen/application/utils/DataSetInjectorForTestService.java b/...ication/src/test/java/fr/insee/queen/application/utils/DataSetInjectorForTestService.java
diff --git a/queen-application/src/test/java/fr/insee/queen/application/utils/JsonTestHelper.java b/queen-application/src/test/java/fr/insee/queen/application/utils/JsonTestHelper.java
@@ -12,7 +12,7 @@
 
 public class JsonTestHelper {
 
-    private final static String DATA_FOLDER = "data/";
+    private static final String DATA_FOLDER = "data/";
 
     public JsonTestHelper() {
         throw new IllegalArgumentException("Utility class");

diff --git a/.../test/java/fr/insee/queen/domain/campaign/service/dummy/CampaignExistenceFakeService.java b/.../test/java/fr/insee/queen/domain/campaign/service/dummy/CampaignExistenceFakeService.java
@@ -25,7 +25,7 @@ public void throwExceptionIfCampaignAlreadyExist(String campaignId) {
 
     @Override
     public void throwExceptionIfCampaignNotLinkedToQuestionnaire(String campaignId, String questionnaireId) {
-
+        // not implemented yet
     }
 
     @Override

diff --git a/...src/test/java/fr/insee/queen/domain/surveyunit/infrastructure/dummy/StateDataFakeDao.java b/...src/test/java/fr/insee/queen/domain/surveyunit/infrastructure/dummy/StateDataFakeDao.java
@@ -35,7 +35,7 @@ public void save(String surveyUnitId, StateData stateData) {
 
     @Override
     public void create(String surveyUnitId, StateData stateData) {
-
+        // not implemented yet
     }
 
     @Override