-
Notifications
You must be signed in to change notification settings - Fork 26
Remove Python 3.8 from wasm/python pyproject.toml files #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Python 3.8 from wasm/python pyproject.toml files #322
Conversation
- Follow-up to InsightSoftwareConsortium#319 commit 2d23742 "COMP: Drop Python 3.8 (end of life)"
"Programming Language :: Python :: 3.8", | ||
"Programming Language :: Python :: 3.9", | ||
"Programming Language :: Python :: 3.10", | ||
"Programming Language :: Python :: 3.11", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I think it's obvious that Python 3.8 can be removed here, I wonder if it's still useful to mention all the other minor Python versions in each pyproject file. What do you think?
The root pyproject.toml file does not mention any Python version:
Line 36 in d3ca819
"Programming Language :: Python", |
Is that also OK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Python Packaging User Guide suggests that those classifiers are only informative, so I guess it may not be necessary to mention each minor Python version number:
Although the list of classifiers is often used to declare what Python versions a project supports, this information is only used for searching and browsing projects on PyPI, not for installing projects. To actually restrict what Python versions a project can be installed on, use the requires-python argument.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The minor versions are a signal to folks browsing the project on PyPI what versions of Python the project has been tested with.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we benefit from explicitly communicating the versions we support :-)
- Follow-up to InsightSoftwareConsortium#319 commit 2d23742 "COMP: Drop Python 3.8 (end of life)"
06aa937
to
2cb4f5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@N-Dekker thanks!
4a471fd
into
InsightSoftwareConsortium:main
"COMP: Drop Python 3.8 (end of life)"