Skip to content

Remove Python 3.8 from wasm/python pyproject.toml files #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

N-Dekker
Copy link
Collaborator

@N-Dekker N-Dekker commented Mar 5, 2025

@N-Dekker N-Dekker requested review from thewtex and tbirdso March 5, 2025 21:11
Comment on lines -21 to 23
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I think it's obvious that Python 3.8 can be removed here, I wonder if it's still useful to mention all the other minor Python versions in each pyproject file. What do you think?

The root pyproject.toml file does not mention any Python version:

"Programming Language :: Python",

Is that also OK?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Python Packaging User Guide suggests that those classifiers are only informative, so I guess it may not be necessary to mention each minor Python version number:

Although the list of classifiers is often used to declare what Python versions a project supports, this information is only used for searching and browsing projects on PyPI, not for installing projects. To actually restrict what Python versions a project can be installed on, use the requires-python argument.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The minor versions are a signal to folks browsing the project on PyPI what versions of Python the project has been tested with.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we benefit from explicitly communicating the versions we support :-)

@N-Dekker N-Dekker changed the title DOC: Remove Python 3.8 from classifiers wasm/python pyproject.toml files Remove Python 3.8 from wasm/python pyproject.toml files Mar 5, 2025
@N-Dekker N-Dekker force-pushed the Remove-Python-3-8-from-pyproject-files branch from 06aa937 to 2cb4f5a Compare March 5, 2025 21:34
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@N-Dekker thanks!

@thewtex thewtex merged commit 4a471fd into InsightSoftwareConsortium:main Mar 6, 2025
19 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants