-
Notifications
You must be signed in to change notification settings - Fork 26
ENH: Bump Python package version to 0.22.0 #326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
And itk Python dep to 5.4.2.
"itk~=5.4.0", | ||
"itk~=5.4.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SuperElastix/elastix still supports ITK 5.4.1, so I guess it might as well say "itk~=5.4.1"
, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no python packages generated for 5.4.1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dzenanz But if I understand correctly, the expression "itk~=5.4.1"
would match both 5.4.1
and 5.4.2
, even if 5.4.1
doesn't exist 😸
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are building against itk 5.4.2
, Bumping the compatible release specification is a good idea:
https://packaging.python.org/en/latest/specifications/version-specifiers/#compatible-release
There are not necessarily binary compatibility issues, but this is a good practice.
In recent ITKRemoteModuleBuildTestPackageAction, these are built on a separate native ARM CI system.
For latest WASM modules.
Thanks Matt! I'm sorry I don't know how to review these 1000+ code changes 🤷 Any suggestion? |
In addition to building the WASM modules, build the Typescript bindings and generate the JavaScript bundles.
@N-Dekker it is not necessary to validate all the changes in pixi.lock or pnpm-lock.yaml :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😄
Thanks, Matt. Are these two files then generated fully automatically? |
As far as I can see, all CI checks pass now, except for "Build / py-dev / test-linux-notebooks (pull_request)", at https://github.com/InsightSoftwareConsortium/ITKElastix/actions/runs/13738452046/job/38427626120?pr=326 saying:
But that's an issue you reported before: #291 So let's merge now! Thanks again Matt! |
👍 yes Thanks @N-Dekker ! |
@thewtex Can you please explain how to generate those files automatically? Maybe tomorrow... 😃 |
And itk Python dep to 5.4.2.
@N-Dekker this is a step for publishing a new Python package version. And it allows us to test recent CI configuration improvements.