BUG: Workaround "direction cosines matrix of the fixed image is invalid" #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set direction matrix to the identity matrix, as a workaround for issue InsightSoftwareConsortium#291 "GroupwiseRegistration notebook: ERROR: the direction cosines matrix of the fixed image is invalid!", reported by Matt McCormick on May 23, 2024.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@thewtex @stefanklein @mstaring I would very much like to have a proper solution for issue #291 ("GroupwiseRegistration notebook: ERROR: the direction cosines matrix of the fixed image is invalid!"), either by adjusting the error checking in elastix VarianceOverLastDimensionMetric or by adjusting the data set. But until we found the right solution, I propose to just merge this workaround, which simply sets the direction to the identity matrix. OK? |
thewtex
approved these changes
Mar 19, 2025
There was a problem hiding this comment.
@N-Dekker thanks for addressing this 🙏
I like your plan.
Would be good to get feedback from @mstaring @stefanklein
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set direction matrix to the identity matrix, as a workaround for issue #291 "GroupwiseRegistration notebook: ERROR: the direction cosines matrix of the fixed image is invalid!", reported by Matt McCormick (@thewtex) on May 23, 2024.
@ViktorvdValk Do you remember that you saw those error messages (as reported by issue #291) when you originally made this notebook? Otherwise I wonder how the errors "sneaked in" afterwards. Could
itk.imread("data/00", itk.F)possibly have changed after you made the notebook? 🤷