-
Notifications
You must be signed in to change notification settings - Fork 26
ENH: Add ITK_Example_TomlFileFormatForParameterFiles.ipynb #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add ITK_Example_TomlFileFormatForParameterFiles.ipynb #329
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
4e6f752
to
5ad9ea5
Compare
@@ -0,0 +1,528 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line #8. import pip._vendor.tomli as tomllib # the same tomllib that's now included in Python v3.11+
Cool!
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thewtex Actually I also liked your suggestion to pip install tomllib
for older versions of Python, but I couldn't remember how to do that exactly. 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@N-Dekker well done ! 🎇
Demonstrates TOML support for elastix registration parameter files and transformation parameter files.
5ad9ea5
to
5dfe125
Compare
FYI, this force-push sets the center of rotation of the initial transformation at |
@thewtex Is it OK to you if we just merge this Jupyter Notebook PR now? The wasm build still fails, but that seems unrelated. The wasm build has a few harmless warnings (
Anyway, it's clearly beyond the scope of this PR 😇 |
@N-Dekker yes, merge sounds good to me. I thought I fixed wasm CI in another PR. I will take another pass when we upgrade to v5.4.3. |
51581d3
into
InsightSoftwareConsortium:main
Demonstrates TOML support for elastix registration parameter files and transformation parameter files.
@thewtex @mstaring @stefanklein Please have a look!