-
Notifications
You must be signed in to change notification settings - Fork 13
COMP: Fix VTK configuration errors. #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COMP: Fix VTK configuration errors. #34
Conversation
36016b4
to
4f3770e
Compare
This makes the module get configured locally. The changes in this PR got inspired from PR 731 in ITK and PR 778 in ITK. Not sure the changes are correct/the best fit for the module's needs, though:
A few VTK-related linking errors are raised when building. Not sure if when PR 778 in ITK gets merged these will be fixed. Finally, in any case, if we get to configure the module correctly and get the VTK linking errors fixed in this PR, the module will not build due to the @schmidje @phcerdan @thewtex can we cast some light about this ? Thanks. |
As in PR #33, CDash CI build errors are again due to the
|
eab588f
to
dda8b26
Compare
Fix VTK configuration errors. Fixes: ``` CMake Deprecation Warning at C:/SDKs/VTK/vtk-head-Bin/lib/cmake/vtk-8.90/vtk-config.cmake:57 (message): The new name for the 'vtkRenderingVolume' component is 'RenderingVolume' Call Stack (most recent call first): C:/SDKs/VTK/vtk-head-Bin/vtk-config.cmake:1 (include) CMakeLists.txt:15 (find_package) CMake Deprecation Warning at C:/SDKs/VTK/vtk-head-Bin/lib/cmake/vtk-8.90/vtk-config.cmake:57 (message): The new name for the 'vtkIOGeometry' component is 'IOGeometry' Call Stack (most recent call first): C:/SDKs/VTK/vtk-head-Bin/vtk-config.cmake:1 (include) CMakeLists.txt:15 (find_package) CMake Deprecation Warning at C:/SDKs/VTK/vtk-head-Bin/lib/cmake/vtk-8.90/vtk-config.cmake:57 (message): The new name for the 'vtkIOLegacy' component is 'IOLegacy' Call Stack (most recent call first): C:/SDKs/VTK/vtk-head-Bin/vtk-config.cmake:1 (include) CMakeLists.txt:15 (find_package) CMake Deprecation Warning at C:/SDKs/VTK/vtk-head-Bin/lib/cmake/vtk-8.90/vtk-config.cmake:57 (message): The new name for the 'vtkIOImage' component is 'IOImage' Call Stack (most recent call first): C:/SDKs/VTK/vtk-head-Bin/vtk-config.cmake:1 (include) CMakeLists.txt:15 (find_package) CMake Deprecation Warning at C:/SDKs/VTK/vtk-head-Bin/lib/cmake/vtk-8.90/vtk-config.cmake:57 (message): The new name for the 'vtkInteractionWidgets' component is 'InteractionWidgets' Call Stack (most recent call first): C:/SDKs/VTK/vtk-head-Bin/vtk-config.cmake:1 (include) CMakeLists.txt:15 (find_package) CMake Deprecation Warning at C:/SDKs/VTK/vtk-head-Bin/lib/cmake/vtk-8.90/vtk-config.cmake:57 (message): The new name for the 'vtkInteractionImage' component is 'InteractionImage' Call Stack (most recent call first): C:/SDKs/VTK/vtk-head-Bin/vtk-config.cmake:1 (include) CMakeLists.txt:15 (find_package) CMake Error at CMakeLists.txt:20 (include): include called with wrong number of arguments. include() only takes one file. ``` raised when configuring the module against ITK and VTK master.
dda8b26
to
1c1d3bd
Compare
@jhlegarreta, Do you think this PR is still accurate? I tested it locally, and it works on my Ubuntu 24.04 box. I'm willing to rebase and merge if you still believe it's the best way to correct the problem from six years ago. |
@hjmjohnson Thanks for the effort. I have not tried this since I contributed with the PR, and have not tried to configure/build any remotes using VTK recently. I do not know whether there is a simpler way to configure VTK now. For sure, we should no longer be trying to support a min VTK 6.x: Hopefully @dzenanz has some insight on ways in which this can be done with less/simpler code. |
I am afraid I have not used this remote module, so I have no particular insight. |
Then my vote is to merge this as is given that Hans succeeded building this locally and build from there. |
648caff
into
InsightSoftwareConsortium:main
Fix VTK configuration errors.
Fixes:
raised when configuring the module against ITK and VTK master.