🐛 🧪 fix test bug #12
Merged
🐛 🧪 fix test bug #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,14 +14,14 @@ testthat::test_that("beta_j_seasonality matches", { | |||
| time_names <- seq(as.Date(model$params$date_start), as.Date(model$params$date_stop), 1) | |||
| location_names <- model$params$location_name | |||
|
|
|||
| beta_j0_hum <- model$params$beta_j0_hum | |||
| beta_j0_hum <- baseline$beta_j0_hum | |||
There was a problem hiding this comment.
The test was previously pulling beta_j0_hum from model$params which is incorrect; it should reference baseline$beta_j0_hum as intended.
Copilot uses AI. Check for mistakes.
| beta_jt_hum_model <- model$patches$beta_jt_human | ||
| beta_jt_hum_expected <- matrix(NA_real_, nrow = length(time_names), ncol = length(location_names)) | ||
|
|
||
| # Baseline Fourier seasonality terms | ||
| a1 <- baseline$a_1_j | ||
| a2 <- baseline$a_2_j | ||
| b1 <- baseline$a_1_j | ||
| b1 <- baseline$b_1_j |
There was a problem hiding this comment.
Fixed a typo where b1 was assigned from baseline$a_1_j; it should use baseline$b_1_j to match the model definition.
Copilot uses AI. Check for mistakes.
| @@ -388,7 +388,7 @@ testthat::test_that("spatial hazard calculations match", { | |||
|
|
|||
| a1 <- baseline$a_1_j | |||
| a2 <- baseline$a_2_j | |||
| b1 <- baseline$a_1_j | |||
| b1 <- baseline$b_1_j | |||
There was a problem hiding this comment.
Similarly, this b1 assignment in the spatial hazard test was pulling from a_1_j by mistake; updated to baseline$b_1_j.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of typos in tests.