Skip to content
This repository has been archived by the owner on Apr 1, 2019. It is now read-only.

Three patches for sample_multi_trancode #9

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Three patches for sample_multi_trancode #9

wants to merge 3 commits into from

Conversation

xzhangxa
Copy link

@xzhangxa xzhangxa commented Mar 3, 2017

If par file is provided each session cmd line is saved twice into m_lines. At final output it would be confusing.

opaque memory usage is disabled of output raw yuv file in
CTranscodingPipeline, but for -vpp_comp all sink inter sessions
need to be changed. check and change it, and there's already code
to change other inter sessions.
@xzhangxa xzhangxa changed the title Remove reduplicate saving of session cmd line Two patches for sample_multi_trancode Mar 4, 2017
@xzhangxa
Copy link
Author

xzhangxa commented Mar 4, 2017

The second patch is for checking opaque memory usage with output raw yuv file when -vpp_comp.

Run with this par file the sample will fail:

-i::h264 C:\data\out.h264 -o::sink -vpp_comp_dst_x 0 -vpp_comp_dst_y 0 -vpp_comp_dst_w 960 -vpp_comp_dst_h 540 -hw -join
-i::h264 C:\data\out1.h264 -o::sink -vpp_comp_dst_x 960 -vpp_comp_dst_y 0 -vpp_comp_dst_w 960 -vpp_comp_dst_h 540 -hw -join
-i::h264 C:\data\out2.h264 -o::sink -vpp_comp_dst_x 0 -vpp_comp_dst_y 540 -vpp_comp_dst_w 960 -vpp_comp_dst_h 540 -hw -join
-i::h264 C:\data\out3.h264 -o::sink -vpp_comp_dst_x 960 -vpp_comp_dst_y 540 -vpp_comp_dst_w 960 -vpp_comp_dst_h 540 -hw -join
-i::source -w 1920 -h 1080 -o::raw dump.yuv -vpp_comp 4 -hw -join

opaque memory usage is disabled in CTranscodingPipeline when output raw yuv, but for -vpp_comp inter sessions all sink sessions need to be changed, like what is done for -vpp_comp_only. Check and change it then the existing inter sessions checking code will change all sink sessions.

QueryPerformanceFrequency is not always 1000000
@xzhangxa xzhangxa changed the title Two patches for sample_multi_trancode Three patches for sample_multi_trancode Mar 21, 2017
@xzhangxa
Copy link
Author

Third patch is to fix -fps option bug on Windows. QueryPerformanceFrequency is not always 1000000.

@onabiull
Copy link

onabiull commented Apr 1, 2019

Please create PR against actual codebase https://github.com/Intel-Media-SDK/MediaSDK/tree/master/samples. This repo would be archived.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants