Skip to content

Orchestration in VDMS with Kubernetes #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 54 commits into from
Apr 9, 2025
Merged

Orchestration in VDMS with Kubernetes #261

merged 54 commits into from
Apr 9, 2025

Conversation

100rish
Copy link
Contributor

@100rish 100rish commented Jan 2, 2025

Closes #246

Copy link
Contributor

Target CPP Coverage: 64.1421%
Source CPP Coverage: 63.0404%

Target Python Coverage: 98.02%
Source Python Coverage: 98.02%

Copy link
Contributor

Target CPP Coverage: 64.2822%
Source CPP Coverage: 64.303%

Target Python Coverage: 97.94%
Source Python Coverage: 97.94%

ifadams
ifadams previously approved these changes Mar 14, 2025
Copy link
Contributor

@ifadams ifadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing was leaping out, but I do have some concerns at the level of complexity of the utilities we're bolting on, and think we might want to have a discussion at some point of teasing apart some of the pieces into more isolated libraries/calls (e.g. VCL, K8s support, etc).

That said, approved.

#272)

* Format Dockerfiles, convert wget to curl, remove duplicate 'option' in CMakeLists due to cmake warning and centralized in main CmakeLists

* Fix base Dockerfile indention

---------

Signed-off-by: cwlacewe <[email protected]>
Copy link
Contributor

@cwlacewe cwlacewe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in my POV. @ifadams, can you review/approve the updates?

Copy link
Contributor

github-actions bot commented Apr 2, 2025

Target CPP Coverage: 64.2822%
Source CPP Coverage: 63.5099%

Target Python Coverage: 97.94%
Source Python Coverage: 97.94%

ifadams
ifadams previously approved these changes Apr 2, 2025
Copy link
Contributor

@ifadams ifadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing leaping out at me. I forget, is docker compose a separate installation or does it just come with a generic docker install? If it does, did we call that out as a req? My skim was pretty rapid...

Copy link
Contributor

github-actions bot commented Apr 9, 2025

Target CPP Coverage: 69.7544%
Source CPP Coverage: 68.9172%

Target Python Coverage: 97.94%
Source Python Coverage: 97.94%

Copy link
Contributor

github-actions bot commented Apr 9, 2025

Target CPP Coverage: 69.7544%
Source CPP Coverage: 68.9262%

Target Python Coverage: 97.94%
Source Python Coverage: 97.94%

@cwlacewe cwlacewe merged commit c8b120b into develop Apr 9, 2025
7 of 8 checks passed
@cwlacewe cwlacewe mentioned this pull request Apr 13, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Orchestration in VDMS with Kubernetes for easier setup of user-defined function environments both locally and on remote servers
4 participants