Skip to content

295 addget fast filters integration #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jul 2, 2025
Merged

295 addget fast filters integration #305

merged 17 commits into from
Jul 2, 2025

Conversation

ifadams
Copy link
Contributor

@ifadams ifadams commented Jun 27, 2025

Initial integration of add/find/list filters

@ifadams ifadams linked an issue Jun 27, 2025 that may be closed by this pull request
Add/Get Fast Filters Integration #295
Closed
@github-actions GitHub Actions
Copy link
Contributor

Target CPP Coverage: 69.7103%
Source CPP Coverage: 67.5632%

Target Python Coverage: 97.94%
Source Python Coverage: 97.94%

@github-actions GitHub Actions
Copy link
Contributor

Target CPP Coverage: 69.7103%
Source CPP Coverage: 67.6009%

Target Python Coverage: 97.94%
Source Python Coverage: 97.94%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 1, 2025

Target CPP Coverage: 69.7103%
Source CPP Coverage: 70.2964%

Target Python Coverage: 97.94%
Source Python Coverage: 97.94%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 1, 2025

Target CPP Coverage: 69.7103%
Source CPP Coverage: 70.2793%

Target Python Coverage: 97.94%
Source Python Coverage: 97.94%

@ifadams ifadams marked this pull request as ready for review July 1, 2025 21:07
cwlacewe
cwlacewe reviewed Jul 1, 2025
View reviewed changes
Copy link
Contributor

@cwlacewe cwlacewe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Pending @s-gobriel input

s-gobriel
s-gobriel previously approved these changes Jul 2, 2025
View reviewed changes
Copy link
Contributor

@s-gobriel s-gobriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

include/vcl/Filter.h
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in the develop branch filter_list_all_names() is already exposed as an external api. this will resolve with merge. but otherwise the create and find filter api looks good to me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must have not synched my local with it correctly, my bad.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025

Target CPP Coverage: 70.8772%
Source CPP Coverage: 71.332%

Target Python Coverage: 97.94%
Source Python Coverage: 97.94%

@cwlacewe cwlacewe merged commit 768bab9 into develop Jul 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwlacewe cwlacewe cwlacewe approved these changes

@s-gobriel s-gobriel s-gobriel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add/Get Fast Filters Integration
3 participants
@ifadams @cwlacewe @s-gobriel