optimize rs2_get_options_list with bulk operation #13613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Dec 18, 2024
src/sensor.h
Outdated
| // type we might want to change power state or encapsulate small transactions into a large one. | ||
| virtual void prepare_for_bulk_operation() {} | ||
| virtual void finished_bulk_operation() {} | ||
| // And ROII, too: |
There was a problem hiding this comment.
Right :) WIll fix, or just remove the line...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, a simple average
rs2_get_options_list()on a D455 was ~350ms.Now it's ~24.
Moved the
prepare_bulk_operation()andfinish_bulk_operation()functions intosensor_baseso they can also be used onsynthetic_sensorand forwarded to the raw sensor.The actual
rs2_get_options_listfunction now prepares and finishes the bulk-operation before/after doing its thing.