Pr275 builderrorfix v4l2compat 5.15to6.11 #278
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Intel RealSense D4XX kernel driver to build against Linux 5.15 up through 6.11 by expanding version checks, refactoring v4l2_subdev pad/video operations, and adjusting driver callbacks.
- Broadened
#if LINUX_VERSION_CODEguards for v4l2 format/state APIs, class_create, and i2c probe/remove signatures - Refactored
ds5_sensor_get/set_fmtandds5_mux_get/set_fmtto usev4l2_subdev_state_get_format, updated pad ops tables - Added error handling in
ds5_g_volatile_ctrland marked functionsstaticwhere needed
Comments suppressed due to low confidence (1)
| unsigned int mipi_csi2_type; | ||
| s64 *sub_stream = NULL; |
There was a problem hiding this comment.
The variables mipi_csi2_type and sub_stream are declared in ds5_substream_init but never used; consider removing them to reduce dead code.
| unsigned int mipi_csi2_type; | |
| s64 *sub_stream = NULL; |
Copilot uses AI. Check for mistakes.
| else | ||
| remote_sd = &state->mux.last_set->sd; | ||
| #ifdef CONFIG_VIDEO_INTEL_IPU6 | ||
| ffmt = &ds5_ffmts[pad]; |
There was a problem hiding this comment.
In ds5_mux_set_fmt, the DS5_MUX_PAD_EXTERNAL case only assigns ffmt under CONFIG_VIDEO_INTEL_IPU6. On non-IPU6 builds this will fall through and return -EINVAL; add a default ffmt assignment outside the IPU6 guard or handle the pad for all configurations.
| ffmt = &ds5_ffmts[pad]; | |
| ffmt = &ds5_ffmts[pad]; | |
| #else | |
| ffmt = &sensor->format; // Default assignment for non-IPU6 builds |
Copilot uses AI. Check for mistakes.
|
Closed and reopened to trigger ci :) |
Pr275 build error fix v4l2compat 5.15to6.11