Fix mutability issue leading to wrong behavior in //ascend and //desc…

…end (#3101)
IntellectualSites · Feb 11, 2025 · 61f4a48 · 61f4a48
1 parent 6a8ea4c
commit 61f4a48
Showing 1 changed file with 2 additions and 14 deletions.
diff --git a/worldedit-core/src/main/java/com/sk89q/worldedit/extension/platform/AbstractPlayerActor.java b/worldedit-core/src/main/java/com/sk89q/worldedit/extension/platform/AbstractPlayerActor.java
@@ -280,14 +280,8 @@ public boolean ascendLevel() {
         int yPlusSearchHeight = y + WorldEdit.getInstance().getConfiguration().defaultVerticalHeight;
         int maxY = Math.min(world.getMaxY(), yPlusSearchHeight) + 2;
 
-        //FAWE start - mutable
-        MutableBlockVector3 mutable = new MutableBlockVector3(x, y, z);
-        //FAWE end
-
         while (y <= maxY) {
-            //FAWE start - mutable
-            if (isLocationGoodForStanding(mutable.mutY(y))
-                    //FAWE end
+            if (isLocationGoodForStanding(BlockVector3.at(x, y, z))
                     && trySetPosition(Vector3.at(x + 0.5, y, z + 0.5))) {
                 return true;
             }
@@ -308,14 +302,8 @@ public boolean descendLevel() {
         int yLessSearchHeight = y - WorldEdit.getInstance().getConfiguration().defaultVerticalHeight;
         int minY = Math.min(world.getMinY() + 1, yLessSearchHeight);
 
-        //FAWE start - mutable
-        MutableBlockVector3 mutable = new MutableBlockVector3(x, y, z);
-        //FAWE end
-
         while (y >= minY) {
-            //FAWE start - mutable
-            if (isLocationGoodForStanding(mutable.mutY(y))
-                    //FAWE end
+            if (isLocationGoodForStanding(BlockVector3.at(x, y, z))
                     && trySetPosition(Vector3.at(x + 0.5, y, z + 0.5))) {
                 return true;
             }