Skip to content

Conversation

@TheMeinerLP
Copy link
Member

Overview

This pr improves the readability of the entity remover and removes some potential memory issue

Description

### Submitter Checklist
- [X] Make sure you are opening from a topic branch (**/feature/fix/docs/ branch** (right side)) and not your main branch.
- [X] Ensure that the pull request title represents the desired changelog entry.
- [X] New public fields and methods are annotated with `@since TODO`.
- [X] I read and followed the [contribution guidelines](https://github.com/IntellectualSites/.github/blob/main/CONTRIBUTING.md).

@TheMeinerLP TheMeinerLP requested a review from a team as a code owner February 4, 2024 15:16
@github-actions github-actions bot added the Feature This PR adds a new feature label Feb 4, 2024
@dordsor21
Copy link
Member

PR would be better suited for upstream tbh

@TheMeinerLP
Copy link
Member Author

@dordsor21 I know that, but last time I was put down a bit to improve code. Since then I've had an aversion to them.
But feel free to copy the idea and pitch it to them. Please understand my decision

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature This PR adds a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants