fix: don't bypass history with //ores #3258
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dordsor21
commented
Aug 1, 2025
dordsor21
commented
- also add copper and update limits
- also restrict ores spawning to region
- also fix caves out of region error
- fixes //caves Permission Issue //Ores Does Not //undo Consistently #3108
Member
|
Given you updated the list of ores: is / was there any plan to add the deepslate variants as well? |
Member
Author
Mm yeah the ore generation settings aren't too obfuscated in the code so wouldn't be impossible |
- also add copper and update limits - also restrict ores spawning to region - also fix caves out of region error - fixes #3108
SirYwell
reviewed
Oct 30, 2025
|
|
||
| public abstract class FaweRegionExtent extends ResettableExtent implements IBatchProcessor { | ||
|
|
||
| private final FaweLimit limit; |
Member
There was a problem hiding this comment.
Can we mark this and the ctor param as nullable?
worldedit-core/src/main/java/com/fastasyncworldedit/core/function/generator/OreGen.java
Outdated
Show resolved
Hide resolved
worldedit-core/src/main/java/com/sk89q/worldedit/extent/Extent.java
Outdated
Show resolved
Hide resolved
| public void generate(Region region, GenBase gen) throws WorldEditException { | ||
| for (BlockVector2 chunkPos : region.getChunks()) { | ||
| gen.generate(chunkPos, new SingleRegionExtent(this, getLimit(), region)); | ||
| gen.generate(chunkPos, new SingleRegionExtent(this, null, region)); |
Member
There was a problem hiding this comment.
Any specific reason for removing the limit, given it can be set on the EditSession and should be respected by all child extents?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.