Skip to content

Conversation

@PierreSchwang
Copy link
Member

Overview

Fixes an issue where reserved was written into the block palette for sponge v3 schematics (example would be masked copies).

Submitter Checklist

  • Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
  • Ensure that the pull request title represents the desired changelog entry.
  • New public fields and methods are annotated with @since TODO.
  • I read and followed the contribution guidelines.

@PierreSchwang PierreSchwang requested a review from a team as a code owner August 26, 2025 22:23
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Aug 26, 2025
@PierreSchwang PierreSchwang force-pushed the fix/spongeV3PaletteReserved branch from 9872a5d to ec7cb33 Compare August 30, 2025 18:59
@dordsor21
Copy link
Member

What exactly is the fix? The change is a little abstract aha

@PierreSchwang
Copy link
Member Author

Uhm, it was something related to an issue reported on discord. When saving a clipboard with some (maybe specific) mask, the writer would add a minecraft:reserved block state into the palette iirc.

I think this fix kinda streamlines it with the FastV2Writer? I'll have to look into it again lol. But this should write reserved as air for some reason (I guess because the state cache is setup that way or something)

@PierreSchwang
Copy link
Member Author

Ah, yeah: https://github.com/IntellectualSites/FastAsyncWorldEdit/blob/main/worldedit-core/src/main/java/com/fastasyncworldedit/core/extent/clipboard/io/FastSchematicWriterV3.java#L144

I replace the ordinal in the resolver function if it's reserved, but don't use the ordinal to retrieve the string representation. I guess updating / replacing the actually BlockStateHolder could be cleaner?

@dordsor21
Copy link
Member

Yeah we shouldn't have __RESERVED__ going into schematics at all ideally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix This PR fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants