feat: fully implement Player#sendFakeBlock #3367
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timongcraft
force-pushed
the
feat/fully-impl-fake-block
branch
from
1909470 to
5fbd4fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR improves the
Player#sendFakeBlockimplementation in Bukkit to support non structure-blocks (used by the CUI).Description
Replaces the structure block specific implementation with a generic implementation to allow API users to send fake blocks containing NBT such as player heads, banners etc.
Submitter Checklist
- [ ] New public fields and methods are annotated with@since TODO.Notes
Tested on Paper 1.21.10-105-main@1f31ee5