Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admin permission override to edit signs #4287

Merged
merged 2 commits into from
Jan 6, 2024

Conversation

SirYwell
Copy link
Member

@SirYwell SirYwell commented Jan 3, 2024

Overview

Fixes #4285

Description

Uses existing permissions to allow editing signs for admins.

Submitter Checklist

Preview Give feedback

@SirYwell SirYwell requested a review from a team as a code owner January 3, 2024 15:13
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Jan 3, 2024
@NotMyFault NotMyFault requested a review from a team January 4, 2024 09:22
@Tamikaschu
Copy link
Contributor

Maybe also apply the permission the sign-coloring?

@SirYwell
Copy link
Member Author

SirYwell commented Jan 5, 2024

Maybe also apply the permission the sign-coloring?

Done.

@NotMyFault NotMyFault merged commit 449af2f into main Jan 6, 2024
10 checks passed
@NotMyFault NotMyFault deleted the fix/admin-perms-edit-sign branch January 6, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix This PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow admins to edit signs in others' plots
4 participants