Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use-flag on spigot servers #4476

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Fix use-flag on spigot servers #4476

merged 3 commits into from
Aug 15, 2024

Conversation

PierreSchwang
Copy link
Member

Overview

Fixes #4469

Description

I'm not proud, but it's the most safe way to fix that spigot bug (https://hub.spigotmc.org/jira/browse/SPIGOT-7813). Generated a list of all interactable 1.21.1 materials. Will be used for spigot servers not having the SpigotMC issue fixed already (basically < 1.21).

I could've limited that to just containers, but that might have inconsistent logic with other interactable blocks and the use-flag.

Submitter Checklist

Preview Give feedback

@PierreSchwang PierreSchwang requested a review from a team as a code owner August 11, 2024 22:15
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Aug 11, 2024
@PierreSchwang
Copy link
Member Author

Im noticing right now that I don't have to filter newer stuff out, as I'm using the string constants and not the enum constants itself. Will remove that later.

@PierreSchwang
Copy link
Member Author

I've removed the previously mentioned filter - still works.
Also adjusted the Dyes right above that, as honeycombs can be used for waxing signs since 1.20 (the check only works for 1.20.1 onwards)

@NotMyFault NotMyFault merged commit 84b1af8 into main Aug 15, 2024
10 checks passed
@NotMyFault NotMyFault deleted the fix/spigotContainerUseFlag branch August 15, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix This PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with Container Protection in PlotSquared 7.3.8-Premium
3 participants