-
-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Execute chunk loading operations outside the main thread #4522
base: main
Are you sure you want to change the base?
Execute chunk loading operations outside the main thread #4522
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't see any obvious errors, and seems to be working ingame. My only nitpicks currently are
- Use a Logger instead of
Throwable#printStackTrace
- I think we are using javax Annotations, instead of Jetbrains Annotations (not 100% sure on that though - another review is required either way)
I would address the above things Pierre raised before merge - we should avoid merging code "smells" |
To be honest, It's hard to get any information about correct code-styling. I can easly find a file with both - NotNull and NonNull annotations. But I'm more than happy to modify my PR to use javax if that's the correct one. |
Yeah it should switch to javax. Any issues already in the code can be fixed as and when but I'm opposed to introducing new "problems" if we don't need to |
… into feature/thread-friendly-command
Now, everything should be fine. |
Overview
Description
Now, main command will wait with further execution until plot center location is asynchronously obtained. This will free the main thread while reaching plot in unloaded chunk
Submitter Checklist
@since TODO
.