Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support fp32 all_reduce and reduce_scatter #389

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

sallyjunjun
Copy link
Collaborator

@sallyjunjun sallyjunjun commented Dec 6, 2024

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

support fp32 all_reduce and reduce_scatter

Modification

add reduce_comm_dtype to decide whether use float32 or bfloat16 to compute tensor in all_reduce and reduce_scatter communication.

internlm using isp parallel with sp size 2, weight size 2. The loss is as follows:
image
Using bf16 reduce, compared with original code without this feature, the loss diversity is within 1e-2.
While using fp32 reduce, loss is different from bf16 reduce.

the tgs is as follows:
image

The following is 7B moe module, with pipeline parallel size 2.
loss:
image

tgs:
image

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@sallyjunjun sallyjunjun force-pushed the add-fp32-reduce branch 2 times, most recently from cbbbc18 to c22a1d1 Compare December 6, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants