support fp32 all_reduce and reduce_scatter #389
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
support fp32 all_reduce and reduce_scatter
Modification
add reduce_comm_dtype to decide whether use float32 or bfloat16 to compute tensor in all_reduce and reduce_scatter communication.
internlm using isp parallel with sp size 2, weight size 2. The loss is as follows:
Using bf16 reduce, compared with original code without this feature, the loss diversity is within 1e-2.
While using fp32 reduce, loss is different from bf16 reduce.
the tgs is as follows:
The following is 7B moe module, with pipeline parallel size 2.
loss:
tgs:
BC-breaking (Optional)
Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
Checklist
Before PR:
After PR: