Fixed button hiding #932#934
Merged
dpgiakatos merged 1 commit intoInternetHealthReport:masterfrom Mar 12, 2025
ia319:bug/932
Merged
Fixed button hiding #932#934dpgiakatos merged 1 commit intoInternetHealthReport:masterfrom ia319:bug/932
dpgiakatos merged 1 commit intoInternetHealthReport:masterfrom
ia319:bug/932
Conversation
Fixed visibility issue with scroll-to-top button: - Replaced v-if with v-show for smoother transitions. - Added <Transition> for fade and slide animations. - Cached results using showScrollTopButton's compute property. - Implemented throttling and buffering for scroll events. - Fixed an issue where buttons could not be hidden during fast scrolling. - Adjusted visibility threshold to 200px for better user experience. - Enhanced accessibility with ARIA properties and focus styles. - Support for screen readers and keyboard navigation. - Added error handling to scrollToTop to improve robustness. - Ensures scrolling works reliably in different environments. Resolved: #932
dpgiakatos
approved these changes
Mar 12, 2025
Member
dpgiakatos
left a comment
dpgiakatos
left a comment
There was a problem hiding this comment.
Thanks. Also, nice description/code presentation.
dpgiakatos
merged commit f4ddca3
into
InternetHealthReport:master
6 of 10 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed visibility issue with scroll-to-top button.
Related issue
Fixes #932
How Has This Been Tested?
Screenshots (if appropriate)
N/A
Types of changes
Checklist: