Skip to content

Support ghc-9.12 #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Support ghc-9.12 #510

merged 4 commits into from
Jan 15, 2025

Conversation

erikd
Copy link
Contributor

@erikd erikd commented Nov 8, 2024

Description

Should not be merged until SRP and most allow-newers are removed.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Self-reviewed the diff

@erikd erikd requested review from nfrisby and lehins as code owners November 8, 2024 02:33
@erikd erikd marked this pull request as draft November 8, 2024 02:33
@erikd erikd force-pushed the erikd/ghc-9.12 branch 4 times, most recently from 8abcd5a to 36fd7e6 Compare November 16, 2024 22:44
@erikd erikd force-pushed the erikd/ghc-9.12 branch 3 times, most recently from 77ee665 to a4c941c Compare December 13, 2024 06:23
@erikd erikd force-pushed the erikd/ghc-9.12 branch 3 times, most recently from dd012f4 to aca2009 Compare January 14, 2025 23:43
@erikd erikd marked this pull request as ready for review January 14, 2025 23:43
@erikd erikd requested a review from a team as a code owner January 14, 2025 23:43
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can definitely merge it with allow-newer stanzas, since the they are conditional on ghc-9.12

Good job on pushing the community to update their packages. Sorry you had to deal with difficult maintainers because of this!

@lehins lehins merged commit c37566a into master Jan 15, 2025
29 checks passed
@lehins lehins deleted the erikd/ghc-9.12 branch January 15, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants