Skip to content

Convert some unit tests to golden tests #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Jun 12, 2025

Changelog

- description: |
    Convert some unit tests to golden tests
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@newhoggy newhoggy force-pushed the newhoggy/convert-some-unit-tests-to-golden-tests branch from 6f695c0 to 89eb2f7 Compare June 14, 2025 12:40
@newhoggy newhoggy marked this pull request as ready for review June 14, 2025 12:40
@newhoggy newhoggy force-pushed the newhoggy/convert-some-unit-tests-to-golden-tests branch 2 times, most recently from 1c8f13b to 7f123a8 Compare June 15, 2025 13:21
@newhoggy newhoggy requested review from a team as code owners June 15, 2025 13:21
@newhoggy newhoggy force-pushed the newhoggy/convert-some-unit-tests-to-golden-tests branch from 7f123a8 to 258bddd Compare June 15, 2025 13:38
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why watchdog was removed?

@newhoggy newhoggy force-pushed the newhoggy/convert-some-unit-tests-to-golden-tests branch from 258bddd to 7c13b1a Compare June 25, 2025 13:36
@newhoggy
Copy link
Contributor Author

Why watchdog was removed?

The watchdog is no longer needed.

@newhoggy newhoggy requested a review from carbolymer June 25, 2025 13:43
@newhoggy newhoggy force-pushed the newhoggy/convert-some-unit-tests-to-golden-tests branch from 7c13b1a to 6bda1c8 Compare June 26, 2025 12:06
@newhoggy newhoggy force-pushed the newhoggy/convert-some-unit-tests-to-golden-tests branch from 6bda1c8 to e5f8cf6 Compare June 27, 2025 09:52
@newhoggy newhoggy force-pushed the newhoggy/convert-some-unit-tests-to-golden-tests branch from e5f8cf6 to 0c55720 Compare June 28, 2025 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants