Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHC 9.2.4 #4887

Closed
wants to merge 6 commits into from
Closed

GHC 9.2.4 #4887

wants to merge 6 commits into from

Conversation

newhoggy
Copy link

@newhoggy newhoggy commented Oct 6, 2022

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, PNG optimization, etc. are updated
  • PR
    • (For external contributions) Corresponding issue exists and is linked in the description
    • Targeting master unless this is a cherry-pick backport
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested


constraints:
dependent-sum >= 0.7.1.0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is annoying. It would be much better if we could put this in a cabal file somewhere, but I'm not sure we can without adding a dead package dependency...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tag: 3825d3abf75f83f406c1f7161883c438dac7277d

-- Needed for ghc-9.2.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. Should we push a patched version to CHaP? upstream looks fairly dead. Perhaps we can remove the dependency, but it is useful

@michaelpj michaelpj closed this Nov 11, 2022
@kwxm kwxm deleted the newhoggy/ghc-9.2.4 branch November 14, 2022 10:52
@kwxm kwxm restored the newhoggy/ghc-9.2.4 branch November 14, 2022 10:52
@kwxm kwxm deleted the newhoggy/ghc-9.2.4 branch November 14, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants