-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor CI workflow #1925
Refactor CI workflow #1925
Conversation
@slozier what do you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have an objection to the concept, but unfortunately I don't think it's working as intended. Build is just producing 3x the same package and no tests are running.
I don't think framework arguments have an impact on build or package. And in any case, we want the packages to include binaries for all frameworks so it should not be restricted. I would replace the build
step with package
and just do a matrix on os
.
For the test issues you're going to have to do add back the build step before running the tests.
I guess we end up repeating the build multiple times, but probably going to be faster overall with everything running in parallel?
Yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
This should get rid of all those false positives due to tests not being parallel-safe, it think. 👍 |
This PR splits each CI run into matrixes to make it easier to debug Ironpython builds and make out what's failing.