Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CI workflow #1925

Merged
merged 3 commits into from
Mar 7, 2025
Merged

Refactor CI workflow #1925

merged 3 commits into from
Mar 7, 2025

Conversation

Lamparter
Copy link
Contributor

@Lamparter Lamparter commented Mar 5, 2025

This PR splits each CI run into matrixes to make it easier to debug Ironpython builds and make out what's failing.

@Lamparter
Copy link
Contributor Author

@slozier what do you think?

Copy link
Contributor

@slozier slozier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have an objection to the concept, but unfortunately I don't think it's working as intended. Build is just producing 3x the same package and no tests are running.

I don't think framework arguments have an impact on build or package. And in any case, we want the packages to include binaries for all frameworks so it should not be restricted. I would replace the build step with package and just do a matrix on os.

For the test issues you're going to have to do add back the build step before running the tests.

I guess we end up repeating the build multiple times, but probably going to be faster overall with everything running in parallel?

@Lamparter
Copy link
Contributor Author

Yes

@Lamparter Lamparter marked this pull request as ready for review March 6, 2025 12:13
@Lamparter Lamparter requested a review from slozier March 6, 2025 12:13
Copy link
Contributor

@slozier slozier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@slozier slozier merged commit 3c7fce2 into IronLanguages:main Mar 7, 2025
17 checks passed
@Lamparter Lamparter deleted the ci-refactor branch March 7, 2025 16:51
@BCSharp
Copy link
Member

BCSharp commented Mar 8, 2025

This should get rid of all those false positives due to tests not being parallel-safe, it think. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants