fixed warnings and packet.hpp encoding #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IronsDu
reviewed
Aug 21, 2020
| @@ -16,8 +16,8 @@ namespace brynet { namespace base { | |||
| size_t element_size; | |||
|
|
|||
| size_t element_num; | |||
| size_t front; /* ջ�� */ | |||
| @@ -359,9 +359,17 @@ namespace brynet { namespace base { | |||
| void read(T& value) | |||
| { | |||
| static_assert(std::is_same<T, typename std::remove_pointer<T>::type>::value, | |||
| "T must a nomal type"); | |||
| "T must be a nomal type"); | |||
| #ifdef BRYNET_HAVE_LANG_CXX17 | |||
There was a problem hiding this comment.
It's not removed, it has been fixed.
The word 'be' has been added for a proper grammer
| @@ -1,6 +1,6 @@ | |||
| #pragma once | |||
|
|
|||
| #include <cstdbool> | |||
There was a problem hiding this comment.
请问是为了什么警告呢？ 我看 https://en.cppreference.com/w/cpp/header/cstdbool， 反而C++17时，不需要cstdbool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.