Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid reporting errors when making PRs across forks #2261

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

adam-vessey
Copy link
Contributor

Purpose / why

Has come up a number of times, of documentation PRs reporting errors due to PRs being made from a fork, so, let's avoid the errors.

See: rossjrw/pr-preview-action#6

What changes were made?

Only generates the preview if the PR is made from the same fork.

Verification

Interested Parties

  • @Islandora/documentation
  • @Islandora/committers

Checklist

Pull-request Reviewer

Pull-request reviewer should ensure the following:

Person Merging

The person merging should ensure the following:

  • Does mkdocs still build successfully? (This is indicated by TravisCI passing. To test locally, and see warnings, see How To Build Documentation.)
  • If pages are renamed or removed, have all internal links to those pages been fixed?
  • If pages are added, have they been linked to or placed in the menu?
  • Did the PR receive at least one approval from a committer, and all issues raised have been addressed?

@github-actions
Copy link

github-actions bot commented Sep 13, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-09-13 21:38 UTC

@seth-shaw-asu seth-shaw-asu merged commit 7e0c8e3 into main Sep 13, 2023
1 check passed
@adam-vessey adam-vessey deleted the fix/fork-preview-errors branch September 14, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants