-
Notifications
You must be signed in to change notification settings - Fork 35
[MOB-11551] create iterableEmbeddedMessageElements class #643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: evan/MOB-11550-iterable-embedded-message-button-class
Are you sure you want to change the base?
[MOB-11551] create iterableEmbeddedMessageElements class #643
Conversation
❌ 7 blocking issues (10 total)
This is from Qlty Cloud, the successor to Code Climate Quality. Learn more. |
@@ -0,0 +1,47 @@ | |||
export class IterableEmbeddedMessageDefaultAction { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found 2 issues:
1. Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]
2. Found 39 lines of similar code in 2 locations (mass = 76) [qlty:similar-code]
@@ -0,0 +1,71 @@ | |||
import { IterableEmbeddedMessageDefaultAction } from './IterableEmbeddedMessageDefaultAction'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
constructor( | ||
title?: string, | ||
body?: string, | ||
mediaUrl?: string, | ||
mediaUrlCaption?: string, | ||
defaultAction?: IterableEmbeddedMessageDefaultAction, | ||
buttons?: IterableEmbeddedMessageElementsButton[], | ||
text?: IterableEmbeddedMessageText[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IterableEmbeddedMessageElementsButton.fromDict(button) | ||
); | ||
|
||
const text = dict.text?.map((text) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,45 @@ | |||
export class IterableEmbeddedMessageText { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -1,2 +1,5 @@ | |||
export * from './IterableEmbeddedManager'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,47 @@ | |||
export class IterableEmbeddedMessageDefaultAction { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found 2 issues:
1. Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]
2. Found 39 lines of similar code in 2 locations (mass = 76) [qlty:similar-code]
@@ -0,0 +1,71 @@ | |||
import { IterableEmbeddedMessageDefaultAction } from './IterableEmbeddedMessageDefaultAction'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
constructor( | ||
title?: string, | ||
body?: string, | ||
mediaUrl?: string, | ||
mediaUrlCaption?: string, | ||
defaultAction?: IterableEmbeddedMessageDefaultAction, | ||
buttons?: IterableEmbeddedMessageElementsButton[], | ||
text?: IterableEmbeddedMessageText[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IterableEmbeddedMessageElementsButton.fromDict(button) | ||
); | ||
|
||
const text = dict.text?.map((text) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,45 @@ | |||
export class IterableEmbeddedMessageText { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔹 JIRA Ticket(s) if any
✏️ Description