Skip to content

[MOB-11542] Update dependencies #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

[MOB-11542] Update dependencies #652

wants to merge 14 commits into from

Conversation

lposen
Copy link
Contributor

@lposen lposen commented Jun 7, 2025

🔹 JIRA Ticket

✏️ Description

Updates React Native to 0.79, as well as any corresponding libraries
Makes sure that interop is supported

Testing

  • Make sure your terminal is running the correct node version (see .nvmrc)
  • Make sure that new architecture is working
    • Open example/ios/Podfile. Make sure the first line is ENV['RCT_NEW_ARCH_ENABLED'] = '1'
    • Open example/android/gradle.properties. Make sure newArchEnabled is set to true
    • Run the steps to clean and reinstall everything
    • Run the steps to start the example app
    • Verify that the app is running correctly on both ios and android (may be slow bc of interop)
  • Make sure that legacy architecture is working
    • Stop the apps
    • Open example/ios/Podfile. Update the first line to ENV['RCT_NEW_ARCH_ENABLED'] = '0'
    • Open example/android/gradle.properties. Change newArchEnabled to false
    • Run the steps to clean and reinstall everything
    • Run the steps to start the example app
    • Verify that the app is running correctly on both ios and android

Clean and reinstall everything

  • Run yarn clean
  • Run rm -rf node_modules example/node_modules
  • cd into example/ios. Run pod deintegrate
  • cd into the root. Run yarn install
  • cd in the the example folder. Run yarn install.
  • cd into the example/ios folder.
    • run bundle install
    • run bundle exec pod install
  • cd into the example/android folder. Run ./gradlew clean

Start the example app

  • Run yarn start from the example folder. Keep this running.
  • Run yarn ios from the example folder.
  • Run yarn android from the example folder.

Base automatically changed from MOB-11576-fix-duplicate-method-issues-for-interop to master June 7, 2025 01:05
Copy link

github-actions bot commented Jun 7, 2025

Lines Statements Branches Functions
Coverage: 38%
38.11% (178/467) 11.29% (20/177) 32.46% (50/154)

@lposen lposen changed the title 0.79 [MOB-11542] Update dependencies Jun 9, 2025
@lposen lposen requested a review from Copilot June 9, 2025 20:47
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates React Native and related dependencies to v0.79.3 with corresponding library bumps, adds codegen configuration for interoperability, and adjusts example project configs to support both new and legacy architectures.

  • Bumps React Native, React, and related tooling versions in root and example projects
  • Introduces codegenConfig and explicit platforms in react-native.config.js to support new architecture
  • Updates iOS and Android example setup (Podfile flags, Gradle wrapper, AppDelegate, scripts, README)

Reviewed Changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
package.json Bumped core/react-native dependencies and added codegenConfig
example/react-native.config.js Explicitly set empty platforms for codegen
example/package.json Updated React/React Native versions and build scripts
example/metro.config.js Updated JSDoc import to @react-native/metro-config
example/ios/ReactNativeSdkExample/AppDelegate.mm Imported and initialized new RCTAppDependencyProvider
example/ios/ReactNativeSdkExample.xcodeproj Regenerated PBX entries for updated pods and targets
example/ios/Podfile Enabled new architecture flag by default
example/android/gradlew(.bat) Added SPDX headers; adjusted APP_HOME resolution
example/android/gradle/wrapper/gradle-wrapper.properties Upgraded Gradle distribution URL
example/android/gradle.properties Enabled newArchEnabled for the example app
example/android/build.gradle Bumped SDK, NDK, build tools, and Kotlin versions
example/android/app/src/.../MainApplication.kt Updated SoLoader.init to use OpenSourceMergedSoMapping
example/android/app/build.gradle Switched JSC flavor coordinates for Android
babel.config.js Split presets into overrides for node_modules vs source
README.md Clarified New Architecture support note
Comments suppressed due to low confidence (4)

example/package.json:9

  • [nitpick] The script name build:android:old is ambiguous; consider renaming to build:android:legacy for clarity on which architecture it targets.
"build:android:old": "react-native build-android --extra-params \"--no-daemon --console=plain -PreactNativeArchitectures=arm64-v8a\"",

README.md:60

  • [nitpick] Reformat the TLDR line to standard notation, e.g. **TL;DR:** Use the New Architecture at your own risk, to improve readability and consistency.
*TLDR;* Use the New Architecture at your own risk --

package.json:169

  • [nitpick] Add a brief comment above codegenConfig explaining its purpose and how to regenerate code (e.g. // React Native codegen config for interop module generation).
"codegenConfig": {

example/react-native.config.js:14

  • [nitpick] Clarify why the codegen script fails here—link the issue or add context so future maintainers understand this workaround.
// Codegen script incorrectly fails without this

@@ -1,6 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.9-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.13-bin.zip
Copy link
Preview

Copilot AI Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider using the -all.zip distribution (e.g. gradle-8.13-all.zip) if you need source and documentation files included, or document why -bin.zip was chosen.

Suggested change
distributionUrl=https\://services.gradle.org/distributions/gradle-8.13-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.13-all.zip

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants