[MOB-7936] creates IterableEmbeddedMessage class #657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
evantk91
changed the title
❌ 2 blocking issues (2 total)
This is from Qlty Cloud, the successor to Code Climate Quality. Learn more. |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -0,0 +1,163 @@ | |||
| import { IterableEmbeddedMessage } from '../embedded/classes/IterableEmbeddedMessage'; | |||
There was a problem hiding this comment.
| @@ -0,0 +1,58 @@ | |||
| import { IterableEmbeddedMessageMetadata } from './IterableEmbeddedMessageMetadata'; | |||
There was a problem hiding this comment.
lposen
reviewed
Jun 9, 2025
| * An interface defining the dictionary object containing the properties for the embedded message. | ||
| */ | ||
| interface EmbeddedMessageDict { | ||
| metadata: IterableEmbeddedMessageMetadata; |
There was a problem hiding this comment.
Please add comments to the props with the information it is expecting
lposen
reviewed
Jun 9, 2025
| if (!dict.metadata) { | ||
| throw new Error('metadata is required'); | ||
| } | ||
| const metadata = IterableEmbeddedMessageMetadata.fromDict(dict.metadata); |
There was a problem hiding this comment.
What if fromDict throws an error for any of these classes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 JIRA Ticket(s) if any
✏️ Description