Use userSessionId for chat history #268
Open
+30
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, all chat history (library) is global for all users. This PR separates them with
userSessionIdso the history (library) appears within the user sessions.High-level logics:
userSessionIdin the chats table to indicate the chat owner.userSessionIdis created or looked up from the localstroage.userSessionIdto the WebSocket so that the chat record is created along with theuserSessionId.userSessionIdis created or looked up from the localstroage.userSessionIdto api/chats in the header to get the chat historyuserSessionIdand queries DB only for chats belonging touserSessionId.