Skip to content

Conversation

@mathomp4
Copy link
Collaborator

@mathomp4 mathomp4 commented Dec 11, 2025

Description

This is the "simple" solution to #1842. The ideal way will be to do so via spack-packages, but since spack-stack 2.0 is out soon, this is the "easy" way.

We can undo this once/if spack/spack-packages#2729 is merged and then get into 2.1

Dependencies

None.

Issues addressed

Addresses #1842 though a true fix is in spack/spack-packages#2729

Applications affected

I suppose anything using udunits will be affected. But then, without this, they shouldn't have been able to run, I'd think (unless the code hardcoded in the path to the xml file).

Systems affected

All that use modulefiles.

Testing

  • CI: Note whether the automatic tests (GitHub actions tests that run automatically for every commit) pass or not
    • GitHub actions CI tests pass
    • GitHub actions CI tests do not pass (provide explanation)
    • GitHub actions CI tests skipped (provide explanation if necessary)
  • New tests added: List and describe any new tests added to GitHub actions
    • ...
  • Additional testing: Add information on any additional tests conducted
    • ...

Checklist

  • This PR addresses one issue/problem/enhancement or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.
  • All necessary updates to the documentation on readthedocs are included in this PR
    • For site config updates, check in particular doc/source/PreConfiguredSites.rst and doc/source/MaintainersSection.rst
  • All necessary updates to the spack-stack wiki will be made when this PR is merged

@mathomp4 mathomp4 requested a review from climbfuji December 11, 2025 14:38
@climbfuji
Copy link
Collaborator

I will skip the tests here. PR #1844 will be testing these changes momentarily.

@climbfuji climbfuji mentioned this pull request Dec 11, 2025
31 tasks
@climbfuji climbfuji self-assigned this Dec 11, 2025
@climbfuji climbfuji moved this to In Progress in spack-stack-2.0.x (2025 Q4) Dec 11, 2025
@climbfuji climbfuji linked an issue Dec 11, 2025 that may be closed by this pull request
@climbfuji climbfuji merged commit e3778a8 into JCSDA:release/2.0 Dec 11, 2025
4 of 7 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in spack-stack-2.0.x (2025 Q4) Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

UDUNITS2_XML_PATH should be set in environment

2 participants