Skip to content

New page and some minor fixes #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

New page and some minor fixes #62

wants to merge 1 commit into from

Conversation

rjplevin
Copy link

  • Added lightgray background color on some images. Previewing the files in Visual Studio Code.app (with default black background) suggested this was necessary since black text was illegible.

  • Added page 'gcam-xml.md' to explain how basic XML processing works in GCAM. [This obviously should be validated by Pralit or others]

  • Fixed a couple of XML elements that needed to be backquoted (policies.md)

…es in Visual Studio Code.app (with default black background) suggested this was necessary.

- Added page 'gcam-xml.md' to explain how basic XML processing works in GCAM.
- Fixed a couple of XML elements that needed to be backquoted (policies.md)
@rplzzz rplzzz requested a review from a team January 17, 2019 02:08
Copy link
Contributor

@pralitp pralitp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Rich. These changes look good. I want to add some details and clarifications to the XML page but I think I will just do that as a separate PR.


To reduce redundancy, most technologies are defined in an element in the XML files called the `global-technology-database`, which we'll abbreviate here as GTDB. This provides common information about technologies, and of which can be overwritten in individual regions. Regional references to technologies in the GTDB are specified using the `stub-technology` element.

The `global-technology-database` element occurs in 54 files in GCAM v5.1.2. As the XML files are read in, these elements are merged according to the rules above. After all of the XML files have been
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's drop the specific numbers here with the reference to the GCAM version. We are trying to avoid having too many places with specifics like this that we would then have to go back and update when things change.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're adding details etc, I assume you can delete the numbers, too, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants