Skip to content

Conversation

@kdorheim
Copy link
Contributor

@kdorheim kdorheim commented Oct 22, 2024

This PR corresponds to the V3.5.0 release. The table below lists the individual model development & associated PRs that are included in this release.

PRs Dev Type Old-New Test Update? Description
#739, #741 minor no documentation changes only
#764 bug fix behavior yes bug fix changed CO2 concentrations
#773 minor no expose soil & detritus rh as model output
#756 code breaking no alpha and volscl impact RF from aerosols and vol output, this PR does introduce code breaking changes in the ini files
#781 major yes change implementation of vol RF to be consistent with other RCM groups
#784 minor no add feature to get all Hector variables
#786 major yes change [CH4] lifetime
#789 major yes new default diff, beta, q10_rh parameter values

kdorheim and others added 5 commits February 23, 2024 12:37
Beta = 0.36 seems incorrect, isn't it 0.53.

beta <- fetchvars(core, NA, BETA())
beta
##              scenario year variable value      units
## 1 Unnamed Hector core   NA     beta  0.53 (unitless)

(...)
The current value is set to 0.36 (note that it is a unitless quantity, hence the (unitless) unit).
Fix a minor numeric inconsistency in the hector vignette
* Github Issue 718. Add papers to Hector manuscript lists, including  V3.2.0 manuscript 

* github issue 727. rename FCH4 to RF_CH4 to match all other RF output

* Add a new release checklist

* github issue 734, add output streams

* quite build message

* github issue 740, add matilda refernces

* github issue 735, add ref temperature period to plot
@JGCRI JGCRI deleted a comment from github-actions bot Feb 26, 2025
@JGCRI JGCRI deleted a comment from github-actions bot Feb 26, 2025
@JGCRI JGCRI deleted a comment from github-actions bot Feb 26, 2025
@JGCRI JGCRI deleted a comment from github-actions bot Mar 28, 2025
@JGCRI JGCRI deleted a comment from github-actions bot Mar 28, 2025
@JGCRI JGCRI deleted a comment from github-actions bot Mar 28, 2025
@JGCRI JGCRI deleted a comment from github-actions bot Mar 28, 2025
kdorheim and others added 9 commits May 29, 2025 14:49
Here we change where the scalers are applied so that the vol, aerosol, and total forcing outputs are updated appropriately. While this PR does not change hector output or behavior between the parameter name change, there are code-breaking changes that have been made to the ini files. The ini files are not backward compatible. 

---------

Co-authored-by: ptrscll <[email protected]>
Ensure 0 forcing in the volcanic input time series during Hector's reference period. Update the old-new test data, as this change affects the total RF and global temperature.
* reformat R code base using stylr and other changes to pass R unit testing 

* add ALL_VARS function that can be used to fetch all of the Hector output variables in R
1. Update methane lifetime parameter Tsoil and Tstrat. 
2. Update the coefficients used in the tau OH equation. 
3. Time-varying natural CH4 emissions
4. Update old-new comparison data
* simplify the input csv data tables 

* add P. Scully to the author list 

* clean up get units function
@JGCRI JGCRI deleted a comment from codecov-commenter Oct 2, 2025
Update the default values of q10_1h, beta, and diff by calibrating Hector to historical observations.
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2025

Codecov Report

❌ Patch coverage is 91.53439% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.78%. Comparing base (a61d64a) to head (9fa91b4).

Files with missing lines Patch % Lines
R/messages.R 20.00% 4 Missing ⚠️
src/simpleNbox.cpp 81.81% 4 Missing ⚠️
src/ch4_component.cpp 66.66% 2 Missing ⚠️
src/csv_outputstream_visitor.cpp 0.00% 2 Missing ⚠️
src/rcpp_constants.cpp 0.00% 2 Missing ⚠️
R/biome.R 98.80% 1 Missing ⚠️
src/forcing_component.cpp 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #755      +/-   ##
==========================================
+ Coverage   80.53%   80.78%   +0.24%     
==========================================
  Files          61       61              
  Lines        6308     6327      +19     
==========================================
+ Hits         5080     5111      +31     
+ Misses       1228     1216      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kdorheim
Copy link
Contributor Author

kdorheim commented Oct 16, 2025

This PR includes the following changes:

  • Minor documentation changes
  • Several variables/parameters were renamed, FCH4 -> RF_CH4, alpha -> aero_scalar, & volscl -> vol_scalar
  • Change RF vol implementation so it is not negative in the future period
  • Expose soil and detritus RH fluxes as possible Hector outputs, RH_DETRITUS() & RH_SOIL()
  • Add ALL_VARS() which helps users fetch all Hector output variables
  • Update [CH4] lifetime parameters
  • Allow for time varying historical N2O and CH4 natural emissions
  • New default parameter values for ocean heat diffusivity, CO2 fertilization, and heterotrophic respiration temperature sensitivity from calibrating Hector to historical observations of gmst (Morice et al. 2021), [CO2] (Meinshausen et al. 2020), and ocean heat content (Kuhlbrodt et al. 2023)

Meinshausen, M., Nicholls, Z. R. J., Lewis, J., Gidden, M. J., Vogel, E., Freund, M., et al. (2020). The shared socio-economic pathway (SSP) greenhouse gas concentrations and their extensions to 2500. Geoscientific Model Development, 13(8), 3571–3605. https://doi.org/10.5194/gmd-13-3571-2020

Morice, C. P., Kennedy, J. J., Rayner, N. A., Winn, J. P., Hogan, E., Killick, R. E., et al. (2021). An updated assessment of near‐surface temperature change from 1850: The HadCRUT5 data set. Journal of Geophysical Research, 126(3). https://doi.org/10.1029/2019jd032361

Kuhlbrodt, T., Voldoire, A., Palmer, M. D., Geoffroy, O., & Killick, R. E. (2023). Historical Ocean Heat Uptake in Two Pairs of CMIP6 Models: Global and Regional Perspectives. Journal of Climate, 36(7), 2183–2203. https://doi.org/10.1175/JCLI-D-22-0468.1

@kdorheim
Copy link
Contributor Author

Compared with Hector V3.2.0, the V3.5.0 version has less heat uptake by the ocean, resulting in higher mean air temperature.

ebm

Due to changes in parametrization, the V3.5.0 has lower CO2 concentrations.

co2_conc

The changes in natural N2O and CH4 emissions, as well as the CH4 lifetime parametrization update, also cause these concentrations to change.

ch4_n2o_conc

@kdorheim kdorheim marked this pull request as ready for review October 16, 2025 15:30
@kdorheim kdorheim changed the title Active Development Branch V3.5.0 Development Oct 16, 2025
@kdorheim kdorheim requested a review from bpbond October 20, 2025 15:12
@bpbond
Copy link
Member

bpbond commented Oct 21, 2025

new default diff, beta, q10_rh parameter values

"new default diff, beta, q10_rh parameter values based on recalibration against X"?

@bpbond
Copy link
Member

bpbond commented Oct 21, 2025

@kdorheim Could you document in a comment to what degree the global_tas and CO2_concentration changes bring the model closer to, or farther from, (1) historical observations and (2) CMIP6?

Copy link
Member

@bpbond bpbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See two comments about clarifying points in the PR itself. Thank you and nice work @kdorheim !

@kdorheim
Copy link
Contributor Author

@bpbond, regarding your question of how these changes affect Hector's alignment with historical observations

Observation V3.2.0 MAE V3.5.0 MAE Change
GMST (Morice et al. 2021) 0.139 0.134 decrease in error by 0.005 C
CO2 (Meinshausen et al. 2020) 1.88 2.33 increase in error by 0.45 ppm
OHC (Kuhlbrodt et al. 2023) 52.6 16.7 decrease in error by 35.9 ZJ

Meinshausen, M., Nicholls, Z. R. J., Lewis, J., Gidden, M. J., Vogel, E., Freund, M., et al. (2020). The shared socio-economic pathway (SSP) greenhouse gas concentrations and their extensions to 2500. Geoscientific Model Development, 13(8), 3571–3605. https://doi.org/10.5194/gmd-13-3571-2020

Morice, C. P., Kennedy, J. J., Rayner, N. A., Winn, J. P., Hogan, E., Killick, R. E., et al. (2021). An updated assessment of near‐surface temperature change from 1850: The HadCRUT5 data set. Journal of Geophysical Research, 126(3). https://doi.org/10.1029/2019jd032361

Kuhlbrodt, T., Voldoire, A., Palmer, M. D., Geoffroy, O., & Killick, R. E. (2023). Historical Ocean Heat Uptake in Two Pairs of CMIP6 Models: Global and Regional Perspectives. Journal of Climate, 36(7), 2183–2203. https://doi.org/10.1175/JCLI-D-22-0468.1

@kdorheim kdorheim merged commit 9631b05 into main Oct 23, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants