Double click on entry at "Check integrity" focus bug fixed

[mulla028]

• Closes Double click on entry at "Check integrity" should focus the entry and field #11997

Description

This PR aims on a bug fix, when user was double clicking on entry at Check Integrity, entry was focused, but not a field in entry editor.

Changes

In src/main/java/org/jabref/gui/entryeditor/EntryEditor.java two lines of code were added to setFocusToField()

1. Comment
2. getScene().getWindow().requestFocus();

This line explicitly brings focus back to the main window containing the Entry Editor. It fixes a field focus bug.

Screenshot of changed UI

As you can see on screenshot bug is fixed!

Mandatory checks

• I own the copyright of the code submitted and I licence it under the MIT license
• Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
• Tests created for changes (if applicable)
• Manually tested changed features in running JabRef (always required)
• Screenshots added in PR description (for UI changes)
• Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
• Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

[mulla028]

@koppor
I really enjoyed contributing on your project! Thank you for this opportunity!
If you have any questions or suggestions regarding this PR, just let me know 🫡

[koppor]

Please re-iterate on the issue description: #11997

Here, especially for you, another description.

1. Start JabRef

2. Open chocolate.bib - you find it at https://github.com/JabRef/jabref/blob/main/src/test/resources/testbib/Chocolate.bib

3. Seelct entry "Cocoa and Cardiovascular Health"

4. Select tab "General" in Entry editor

5. Select field DOI
   

6. Go to Menu "Quality"

7. Click on "Check integrity"

8. Double click on the first entry "Corti_2009"
   

9. See that nothing happens

In Step 9, the tab "Requried fiels" and the field "Citatoinkey" should be focused.

[mulla028]

Please re-iterate on the issue description: #11997

Here, especially for you, another description.

1. Start JabRef
2. Open chocolate.bib - you find it at https://github.com/JabRef/jabref/blob/main/src/test/resources/testbib/Chocolate.bib
3. Seelct entry "Cocoa and Cardiovascular Health"
4. Select tab "General" in Entry editor
5. Select field DOI
   
6. Go to Menu "Quality"
7. Click on "Check integrity"
8. Double click on the first entry "Corti_2009"
   
9. See that nothing happens

In Step 9, the tab "Requried fiels" and the field "Citatoinkey" should be focused.

Thank you for your feedback! Will do my best!

[mulla028]

@koppor
You mean that after I opened General tab, and then in Check Integrity once I double click on entry it should focus on both fields:

1. Citation Key
2. Field?

[Siedlerchr]

It should focus on the field that is reported in the integrity check

[mulla028]

It should focus on the field that is reported in the integrity check

Thank you for your response! I'm pretty new to this project. Would it be possible to share a little detailed description? If not, I will do my best to figure all out myself.

[mulla028]

@Siedlerchr
What I don't understand is that current PR supports this feature according on as much I understand.
Following an example by @koppor, he claims that If I click on the first entry Corti2009 nothing happens. However, my end shows me that current field CitationKey focused.
Sharing with you screenshot:

Please let me know if I misunderstand you! Thank you!

[Siedlerchr]

That is indeed correct, however, in my tests jumping to another tab only works sometimes:

1. Open chocolate bib
2. check integrity
3. click on an entry with DOI => The required information tab stays open

However, if I now select the general Tab of an entry, I am able to jump to it/again to it
Same applies to pages field

Please check why the tab needs to have been selected first

[mulla028]

That is indeed correct, however, in my tests jumping to another tab only works sometimes:

1. Open chocolate bib
2. check integrity
3. click on an entry with DOI => The required information tab stays open

However, if I now select the general Tab of an entry, I am able to jump to it/again to it Same applies to pages field

Please check why the tab needs to have been selected first

Oh now I understand where you are getting at! Thank you!