Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge entry buttons #12070

Draft
wants to merge 27 commits into
base: main
Choose a base branch
from
Draft

Merge entry buttons #12070

wants to merge 27 commits into from

Conversation

tohfas
Copy link

@tohfas tohfas commented Oct 24, 2024

Description of Changes

We have made several enhancements to streamline the user interface and improve usability based on the discussed issue. The key changes include:

  1. Merged Buttons
    Consolidated the existing buttons related to adding new entries into a single button. This reduces UI clutter and confusion for newcomers while retaining all essential functionality. The merged dialog now provides multiple tabs for different types of entry creation, including:

  2. Implemented Key Bindings
    Key binding functionalities have been enhanced and new bindings added for the features

    • Ctrl+Shift+N for "New entry from text"
  3. Modified Dialog Box Size
    The size of the "New entry" dialog has been adjusted to be wider (1000px) to better accommodate the multiple tabs and improve readability on different screen sizes.

Jabref_DialogBox_Buttons

Reason for Changes

These changes were implemented to:

  • Reduce complexity in the user interface by merging overlapping functionalities
  • Improve efficiency for experienced users through key bindings
  • Enhance visual accessibility with a larger dialog box

Link to the Closed Issue

Closes #8808

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

src/main/java/module-info.java Outdated Show resolved Hide resolved
src/main/java/org/jabref/Launcher.java Outdated Show resolved Hide resolved
src/main/java/org/jabref/gui/frame/MainToolBar.java Outdated Show resolved Hide resolved
@koppor koppor mentioned this pull request Oct 24, 2024
7 tasks
@Siedlerchr
Copy link
Member

The width is way too large, please make it half the size

@tohfas
Copy link
Author

tohfas commented Oct 25, 2024

The width is way too large, please make it half the size

Hi @koppor. This is done, changed it to 500px (half of 1000px). Thanks.

src/main/java/module-info.java Outdated Show resolved Hide resolved
src/main/java/org/jabref/Launcher.java Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
src/main/java/org/jabref/gui/entrytype/EntryTypeView.java Outdated Show resolved Hide resolved
Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not fix the issue.

Read again #8808 (comment)

One modal. Title: "New entry" (base on the code of dialog "Select entry type"


Currently, there are four buttons:

image

@koppor koppor marked this pull request as draft October 26, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge some (or all) of the "new entry" related buttons
4 participants