Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix-issue 11948 #12073

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix-issue 11948 #12073

wants to merge 1 commit into from

Conversation

Kaven668
Copy link

@Kaven668 Kaven668 commented Oct 24, 2024

Describe the changes you have made here: what, why, ...
Link the issue that will be closed, e.g., "Closes #333". If your PR closes a koppor issue, link it using its URL, e.g., "Closes koppor#47".

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor
Copy link
Member

koppor commented Oct 24, 2024

This fixes #11948

@koppor
Copy link
Member

koppor commented Oct 24, 2024

The current code DOES NOT fix the issue.

_ still needs tobe disallowed in the title

It should be allowed in the citation key.

The issue states:

Modify org.jabref.logic.integrity.LatexIntegrityChecker#check to ignore error TTEM03 in the citation key (org.jabref.model.entry.field.InternalField#KEY_FIELD)

Please re-try.

@koppor koppor marked this pull request as draft October 24, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reset of all preferences should be accessible through Options/Preferences Code for icons
2 participants