Fix BibTeX "twin" at citation relations

[koppor]

Follow-ujp to #12123

• Add getter+setter for "cites" to BibEntry
• Refactor CitationsRelationsTabViewModel
• Group citation keys together in JabRef_en.properties
• We fixed an issue where the import of an entry cited by an entry caused a change of the citation key of the citing entry.

I think, CHANGELOG.md entry too special, thus not adding.

Mandatory checks

• I own the copyright of the code submitted and I licence it under the MIT license
• Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
• Tests created for changes (if applicable)
• Manually tested changed features in running JabRef (always required)
• Screenshots added in PR description (for UI changes)
• Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
• Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

[Siedlerchr]

This reads weird. We should make this consistent with plural check if > 1

[koppor]

First introduced at #10732. Long call w/ @calixtus We never wrote it down as follow-up.

TL;DR: It’s not just singular and plural

• zero → “لم نزرع أي شجرة حتى الآن”
• one → “لقد زرعنا شجرة ١ حتى الآن”
• two → “لقد زرعنا شجرتين ٢ حتى الآن”
• few → “لقد زرعنا ٣ شجرات حتى الآن”
• many → “لقد زرعنا ١١ شجرة حتى الآن”
• other → “لقد زرعنا ١٠٠ شجرة حتى الآن”

Longer: https://phrase.com/blog/posts/pluralization/

We decided to remove singular/plural completely and translate only one thing.

@HoussemNasri Seeing #9243, WDYT?

[calixtus]

Should we write an ADR?

[HoussemNasri]

It would be great if the translation was accurate, but I think it should be fine. For example, both of the following variations are understandable for anyone who reads Arabic. I'm not sure about grammatical correctness, however.

zero → “لقد زرعنا 0 شجرة حتى الآن”
one → “لقد زرعنا ١ شجرة حتى الآن”

Or we could go with something like "Number of entries imported: 3," but that's not necessary, in my opinion.

[Siedlerchr]

can't you use flatmap with filter is Present check

[koppor]

Tried, was very red:

or

---

Alternative would be

        Arrays.stream(this.getField(StandardField.CITES).orElse("").split(","))
              .map(String::trim)
              .filter(key -> !key.isEmpty())
              .collect(Collectors.toCollection(LinkedHashSet::new));

but I don't like the orElse(""), because this is hacky, isn't it?

[github-actions]

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.