Tabular UI for naming linked files #12624

priyanshu16095 · 2025-03-05T15:11:31Z

Closes #11368

This PR adds a tabular construct similar to "Key patterns" for "Linked files name" in the Linked files tab in preferences.

Mandatory checks

I own the copyright of the code submitted and I licence it under the MIT license
Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
[/] Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for UI changes)
Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

src/main/java/org/jabref/gui/commonfxcontrols/PatternSuggestionCell.java

src/main/java/org/jabref/gui/libraryproperties/keypattern/KeyPatternPropertiesViewModel.java

src/main/java/org/jabref/gui/linkedfile/LinkedFileNamePatternsPanel.java

trag-bot · 2025-04-18T19:37:25Z

src/main/java/org/jabref/gui/linkedfile/LinkedFileNamesPanelItemModel.java

+    private final StringProperty pattern = new SimpleStringProperty("");
+
+    public LinkedFileNamesPanelItemModel(EntryType entryType, String pattern) {
+        Objects.requireNonNull(entryType);


The use of Objects.requireNonNull is discouraged. Instead, the @nonnull annotation from JSpecify should be used to ensure non-null values.

trag-bot · 2025-04-18T19:37:27Z

src/main/java/org/jabref/gui/linkedfile/LinkedFileNamesPanelItemModel.java

+
+    public LinkedFileNamesPanelItemModel(EntryType entryType, String pattern) {
+        Objects.requireNonNull(entryType);
+        Objects.requireNonNull(pattern);


The use of Objects.requireNonNull is discouraged. Instead, the @nonnull annotation from JSpecify should be used to ensure non-null values.

src/main/java/org/jabref/gui/linkedfile/LinkedFileNamePatternsPanelViewModel.java

src/main/java/org/jabref/gui/preferences/citationkeypattern/CitationKeyPatternTabViewModel.java

src/main/java/org/jabref/logic/exporter/MetaDataSerializer.java

src/main/java/org/jabref/logic/externalfiles/LinkedFileHandler.java

jabref-machine · 2025-04-18T20:48:07Z

JUnit tests are failing. You can see which checks are failing by locating the box "Some checks were not successful" on the pull request page. To see the test output, locate "Tests / Unit tests (pull_request)" and click on it.

You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide.

src/main/java/org/jabref/gui/linkedfile/LinkedFileNamePatternsPanel.java

src/main/java/org/jabref/gui/linkedfile/LinkedFileNamePatternsPanelViewModel.java

trag-bot · 2025-04-18T21:00:55Z

src/main/java/org/jabref/gui/preferences/citationkeypattern/CitationKeyPatternTabViewModel.java


 public class CitationKeyPatternTabViewModel implements PreferenceTabViewModel {

+    private static final String DEFAULT_ENTRY_TYPE = "default";


Literals in code should be private final or take a Java comment, except for constant declarations. This is a constant declaration, so it is acceptable.

src/main/java/org/jabref/gui/preferences/linkedfiles/LinkedFilesTabViewModel.java

priyanshu16095 · 2025-04-18T21:06:03Z

Recording.2025-04-19.mp4

Works fine, solved the problem of not storing values.
After resolving conflicts, I pulled the changes, after which the checks failed as this newly added task is giving some error.

Please review.

src/main/java/org/jabref/logic/citationkeypattern/GlobalCitationKeyPatterns.java

src/main/java/org/jabref/logic/linkedfile/AbstractLinkedFileNamePatterns.java

jabref-machine · 2025-05-24T08:39:23Z

Your pull request conflicts with the target branch.

Please merge upstream/main with your code. For a step-by-step guide to resolve merge conflicts, see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-using-the-command-line.

trag-bot · 2025-05-24T08:39:55Z

@trag-bot didn't find any issues in the code! ✅✨

priyanshu16095 added 26 commits February 13, 2025 03:42

Add fix options for integrity issues

9b11edf

Fix the check

02d8e75

Add a missing entry for Localization.lang

754b6ad

Fix the check

696f904

Refactor code

4ab36a8

Fix the check

28de796

Add a CHANGELOG.md entry

70ae8eb

Refactor the code

77df6ea

Make use of IntegrityIssue enum

30c81ce

Add keys in Localization.lang

5b389da

Refactor the code

3a0d9a1

Remove use of enum

a04e06a

Remove use of enum from PageChecker class

8e9341a

Add fixAll method

235c74f

Add a check for fixAll and fixByType method

9839137

Fix a bug

5754680

Use dialogService.notify() to notify

8f7bdc2

Remove unused imports

f57719c

Merge branch 'main' into integrityCheckActions

2105a13

Merge branch 'main' into integrityCheckActions

e37ba79

Add tests for methods

139777e

Fix the check and updates based on review

39dbfd1

Use enum for passing issue message

16e9817

Fix the checkstyle check

102e789

Add the gui

92d91b5

Add files in logic directory

b726f30

priyanshu16095 changed the title ~~Tabular UI~~ Tabular UI for naming linked files Mar 5, 2025

priyanshu16095 added 3 commits March 5, 2025 20:59

Revert changes in three files

86518fc

Revert some more files

6f985ec

Revert some more files

5ea4754