Tabular UI for naming linked files#12624
Tabular UI for naming linked files#12624priyanshu16095 wants to merge 67 commits intoJabRef:mainfrom
Conversation
src/main/java/org/jabref/gui/preferences/citationkeypattern/CitationKeyPatternTabViewModel.java
Show resolved
Hide resolved
src/main/java/org/jabref/gui/preferences/citationkeypattern/CitationKeyPatternTabViewModel.java
Show resolved
Hide resolved
|
JUnit tests are failing. You can see which checks are failing by locating the box "Some checks were not successful" on the pull request page. To see the test output, locate "Tests / Unit tests (pull_request)" and click on it. You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide. |
src/main/java/org/jabref/gui/linkedfile/LinkedFileNamePatternsPanel.java
Show resolved
Hide resolved
src/main/java/org/jabref/gui/linkedfile/LinkedFileNamePatternsPanelViewModel.java
Show resolved
Hide resolved
|
|
||
| public class CitationKeyPatternTabViewModel implements PreferenceTabViewModel { | ||
|
|
||
| private static final String DEFAULT_ENTRY_TYPE = "default"; |
There was a problem hiding this comment.
Literals in code should be private final or take a Java comment, except for constant declarations. This is a constant declaration, so it is acceptable.
src/main/java/org/jabref/gui/preferences/linkedfiles/LinkedFilesTabViewModel.java
Show resolved
Hide resolved
src/main/java/org/jabref/gui/preferences/linkedfiles/LinkedFilesTabViewModel.java
Show resolved
Hide resolved
src/main/java/org/jabref/logic/citationkeypattern/GlobalCitationKeyPatterns.java
Show resolved
Hide resolved
src/main/java/org/jabref/logic/linkedfile/AbstractLinkedFileNamePatterns.java
Show resolved
Hide resolved
|
Your pull request conflicts with the target branch. Please merge |
|
@trag-bot didn't find any issues in the code! ✅✨ |
|
This pull requests was closed without merging. You have been unassigned from the respective issue #11368. In case you closed the PR for yourself, you can re-open it. Please also check After submission of a pull request in CONTRIBUTING.md. |

Closes #11368
This PR adds a tabular construct similar to "Key patterns" for "Linked files name" in the Linked files tab in preferences.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)