Add quality checker for journal abbrevs

jabgui/src/main/java/org/jabref/gui/preferences/journals/JournalAbbreviationsTab.java

@@ -36,6 +36,9 @@
 import jakarta.inject.Inject;
 import org.controlsfx.control.textfield.CustomTextField;
 
+import java.util.List;
+import java.util.stream.Collectors;
+
 /**
  * This class controls the user interface of the journal abbreviations dialog. The UI elements and their layout are
  * defined in the FXML file.
@@ -59,6 +62,7 @@ public class JournalAbbreviationsTab extends AbstractPreferenceTabView<JournalAb
 
     @FXML private CustomTextField searchBox;
     @FXML private CheckBox useFJournal;
+    @FXML private CheckBox validateAbbreviations;
 
     @Inject private TaskExecutor taskExecutor;
     @Inject private JournalAbbreviationRepository abbreviationRepository;
@@ -87,17 +91,61 @@ private void initialize() {
 
         searchBox.setPromptText(Localization.lang("Search..."));
         searchBox.setLeft(IconTheme.JabRefIcons.SEARCH.getGraphicNode());
+
+        validateAbbreviations.selectedProperty().bindBidirectional(viewModel.validateAbbreviationsProperty());
     }
 
     private void setUpTable() {
         journalTableNameColumn.setCellValueFactory(cellData -> cellData.getValue().nameProperty());
         journalTableNameColumn.setCellFactory(TextFieldTableCell.forTableColumn());
+        journalTableNameColumn.setOnEditCommit(event -> {
+            if (viewModel.validateAbbreviationsProperty().get()) {
+                AbbreviationViewModel item = event.getRowValue();
+                String newValue = event.getNewValue();
+                List<ValidationResult> results = viewModel.validateAbbreviation(item.getName(), newValue, item.getAbbreviation());
+                if (!results.isEmpty()) {
+                    event.consume();
+                    dialogService.showErrorDialogAndWait(Localization.lang("Validation Error"), 
+                        results.stream()
+                            .map(ValidationResult::getMessage)
+                            .collect(Collectors.joining("\n")));
+                }
+            }
+        });
 
         journalTableAbbreviationColumn.setCellValueFactory(cellData -> cellData.getValue().abbreviationProperty());
         journalTableAbbreviationColumn.setCellFactory(TextFieldTableCell.forTableColumn());
+        journalTableAbbreviationColumn.setOnEditCommit(event -> {
+            if (viewModel.validateAbbreviationsProperty().get()) {
+                AbbreviationViewModel item = event.getRowValue();
+                String newValue = event.getNewValue();
+                List<ValidationResult> results = viewModel.validateAbbreviation(item.getName(), item.getAbbreviation(), newValue);
+                if (!results.isEmpty()) {
+                    event.consume();
+                    dialogService.showErrorDialogAndWait(Localization.lang("Validation Error"), 
+                        results.stream()
+                            .map(ValidationResult::getMessage)
+                            .collect(Collectors.joining("\n")));
+                }
+            }
+        });
 
         journalTableShortestUniqueAbbreviationColumn.setCellValueFactory(cellData -> cellData.getValue().shortestUniqueAbbreviationProperty());
         journalTableShortestUniqueAbbreviationColumn.setCellFactory(TextFieldTableCell.forTableColumn());
+        journalTableShortestUniqueAbbreviationColumn.setOnEditCommit(event -> {
+            if (viewModel.validateAbbreviationsProperty().get()) {
+                AbbreviationViewModel item = event.getRowValue();
+                String newValue = event.getNewValue();
+                List<ValidationResult> results = viewModel.validateAbbreviation(item.getName(), item.getAbbreviation(), newValue);
+                if (!results.isEmpty()) {
+                    event.consume();
+                    dialogService.showErrorDialogAndWait(Localization.lang("Validation Error"), 
+                        results.stream()
+                            .map(ValidationResult::getMessage)
+                            .collect(Collectors.joining("\n")));
+                }
+            }
+        });
 
         actionsColumn.setCellValueFactory(cellData -> cellData.getValue().nameProperty());
         new ValueTableCellFactory<AbbreviationViewModel, String>()

jabgui/src/main/java/org/jabref/gui/preferences/journals/JournalAbbreviationsTabViewModel.java

@@ -49,6 +49,7 @@ public class JournalAbbreviationsTabViewModel implements PreferenceTabViewModel
     private final SimpleBooleanProperty isEditableAndRemovable = new SimpleBooleanProperty(false);
     private final SimpleBooleanProperty isAbbreviationEditableAndRemovable = new SimpleBooleanProperty(false);
     private final SimpleBooleanProperty useFJournal = new SimpleBooleanProperty(true);
+    private final SimpleBooleanProperty validateAbbreviations = new SimpleBooleanProperty(true);
 
     private final DialogService dialogService;
     private final TaskExecutor taskExecutor;
@@ -66,6 +67,9 @@ public JournalAbbreviationsTabViewModel(JournalAbbreviationPreferences abbreviat
         this.journalAbbreviationRepository = Objects.requireNonNull(journalAbbreviationRepository);
         this.abbreviationsPreferences = abbreviationsPreferences;
 
+        useFJournal.setValue(abbreviationsPreferences.shouldUseFJournalField());
+        validateAbbreviations.setValue(abbreviationsPreferences.shouldValidateAbbreviations());
+
         abbreviationsCount.bind(abbreviations.sizeProperty());
         currentAbbreviation.addListener((observable, oldValue, newValue) -> {
             boolean isAbbreviation = (newValue != null) && !newValue.isPseudoAbbreviation();
@@ -103,6 +107,10 @@ public JournalAbbreviationsTabViewModel(JournalAbbreviationPreferences abbreviat
                 }
             }
         });
+
+        // Bind preferences
+        useFJournal.addListener((obs, oldValue, newValue) -> abbreviationsPreferences.setUseFJournalField(newValue));
+        validateAbbreviations.addListener((obs, oldValue, newValue) -> abbreviationsPreferences.setValidateAbbreviations(newValue));
     }
 
     @Override
@@ -387,4 +395,17 @@ public SimpleBooleanProperty isFileRemovableProperty() {
     public SimpleBooleanProperty useFJournalProperty() {
         return useFJournal;
     }
+
+    public BooleanProperty validateAbbreviationsProperty() {
+        return validateAbbreviations;
+    }
+
+    public void setValidateAbbreviations(boolean validateAbbreviations) {
+        this.validateAbbreviations.set(validateAbbreviations);
+    }
+
+    public List<ValidationResult> validateAbbreviation(String name, String abbreviation, String shortestUniqueAbbreviation) {
+        Abbreviation abbreviationObject = new Abbreviation(name, abbreviation, shortestUniqueAbbreviation);
+        return journalAbbreviationRepository.getValidationIssues();
+    }
 }